From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40889C433DF for ; Thu, 30 Jul 2020 14:51:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C23C2070B for ; Thu, 30 Jul 2020 14:51:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JyEzzjku" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C23C2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k19uP-0001FD-9G for qemu-devel@archiver.kernel.org; Thu, 30 Jul 2020 10:51:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k19tO-0008RS-Ot for qemu-devel@nongnu.org; Thu, 30 Jul 2020 10:50:46 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:30759 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k19tM-0001P8-6i for qemu-devel@nongnu.org; Thu, 30 Jul 2020 10:50:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596120642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QKdaHfInRYHIxkBP/pUCz02HG3CYUqXvp2sa+CUqoac=; b=JyEzzjkueYPga0GptsXpytICvezPsl1VvS2fDAYHGMP43UqGNm+3dFxDWDNKFINTP4ZrgW wNoiF4g6SosFjK8HB71gwzhPMed11d6bQXhAZ9chu6BaBHX5Wqg+aFs1qzhaC2gXgP8eGl 326mm19icIo1i4CRniDogdeYds+SMFI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-CYWkaqecMVuaDxhBM9_Nfw-1; Thu, 30 Jul 2020 10:50:39 -0400 X-MC-Unique: CYWkaqecMVuaDxhBM9_Nfw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 402278014D7; Thu, 30 Jul 2020 14:50:38 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4EA6B712D9; Thu, 30 Jul 2020 14:50:35 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CCA961132FD2; Thu, 30 Jul 2020 16:50:33 +0200 (CEST) From: Markus Armbruster To: Max Reitz Subject: Re: [PATCH] qapi: Delete unwanted indentation of top-level expressions References: <20200730091656.2633334-1-armbru@redhat.com> <28f91ce9-2f7d-d4b9-a300-c778c6c20992@redhat.com> Date: Thu, 30 Jul 2020 16:50:33 +0200 In-Reply-To: <28f91ce9-2f7d-d4b9-a300-c778c6c20992@redhat.com> (Max Reitz's message of "Thu, 30 Jul 2020 15:11:13 +0200") Message-ID: <87r1stvyyu.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/30 03:41:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, jsnow@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Max Reitz writes: > On 30.07.20 11:16, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> qapi/block-core.json | 24 ++++++++++++------------ >> qapi/ui.json | 4 ++-- >> 2 files changed, 14 insertions(+), 14 deletions(-) >> >> diff --git a/qapi/block-core.json b/qapi/block-core.json >> index ab7bf3c612..bdcc8e5f9f 100644 >> --- a/qapi/block-core.json >> +++ b/qapi/block-core.json >> @@ -1847,8 +1847,8 @@ >> # >> # Since: 4.0 >> ## >> - { 'enum': 'BlockPermission', >> - 'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize', >> +{ 'enum': 'BlockPermission', >> + 'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize', >> 'graph-mod' ] } > > Do we want to keep the alignment at the opening parenthesis here? Yes, we do. Thanks!