From: Nathan Lynch <nathanl@linux.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Tyrel Datwyler <tyreld@linux.ibm.com>,
mwb@linux.vnet.ibm.com, msuchanek@suse.de,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/pseries: fix of_read_drc_info_cell() to point at next record
Date: Thu, 12 Mar 2020 10:56:18 -0500 [thread overview]
Message-ID: <87r1xx36u5.fsf@linux.ibm.com> (raw)
In-Reply-To: <87imjai0wp.fsf@mpe.ellerman.id.au>
Michael Ellerman <mpe@ellerman.id.au> writes:
>
> It would also be *really* nice if we had some unit tests for this
> parsing code, it's demonstrably very bug prone.
Can you say more about what form unit tests could take? Like some self
tests that run at boot time, or is there a way to run the code in a user
space test harness?
next prev parent reply other threads:[~2020-03-12 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 2:45 [PATCH] powerpc/pseries: fix of_read_drc_info_cell() to point at next record Tyrel Datwyler
2020-03-10 17:25 ` Nathan Lynch
2020-03-10 18:18 ` Tyrel Datwyler
2020-03-12 5:43 ` Michael Ellerman
2020-03-12 15:56 ` Nathan Lynch [this message]
2020-03-13 2:29 ` Michael Ellerman
2020-03-12 21:34 ` Tyrel Datwyler
2020-03-13 2:16 ` Michael Ellerman
2020-03-26 12:06 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1xx36u5.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=mwb@linux.vnet.ibm.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.