From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: Drop I915_RESET_TIMEOUT and friends
Date: Wed, 26 Feb 2020 11:27:58 +0200 [thread overview]
Message-ID: <87r1yhsnoh.fsf@intel.com> (raw)
In-Reply-To: <20200225143604.500731-2-chris@chris-wilson.co.uk>
On Tue, 25 Feb 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> These were used to set various timeouts for the reset procedure
> (deciding when the engine was dead, and even if the reset itself was not
> making forward progress). No longer used.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
\o/
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index de1f1cbcc41d..6b56f31c850f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -611,12 +611,6 @@ struct i915_gem_mm {
> #define I915_IDLE_ENGINES_TIMEOUT (200) /* in ms */
>
> unsigned long i915_fence_timeout(const struct drm_i915_private *i915);
> -#define I915_RESET_TIMEOUT (10 * HZ) /* 10s */
> -
> -#define I915_ENGINE_DEAD_TIMEOUT (4 * HZ) /* Seqno, head and subunits dead */
> -#define I915_SEQNO_DEAD_TIMEOUT (12 * HZ) /* Seqno dead with active head */
> -
> -#define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no recovery? */
>
> /* Amount of SAGV/QGV points, BSpec precisely defines this */
> #define I915_NUM_QGV_POINTS 8
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-26 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 14:36 [Intel-gfx] [PATCH 1/3] drm/i915: Replace the hardcoded I915_FENCE_TIMEOUT Chris Wilson
2020-02-25 14:36 ` [Intel-gfx] [PATCH 2/3] drm/i915: Drop I915_RESET_TIMEOUT and friends Chris Wilson
2020-02-26 9:27 ` Jani Nikula [this message]
2020-02-25 14:36 ` [Intel-gfx] [PATCH 3/3] drm/i915: Drop I915_IDLE_ENGINES_TIMEOUT Chris Wilson
2020-02-26 9:19 ` [Intel-gfx] [PATCH 1/3] drm/i915: Replace the hardcoded I915_FENCE_TIMEOUT Jani Nikula
2020-02-26 9:27 ` Jani Nikula
2020-02-26 16:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork
2020-02-26 17:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-27 7:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1yhsnoh.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.