From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A060C3524D for ; Tue, 4 Feb 2020 09:11:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC9612084E for ; Tue, 4 Feb 2020 09:11:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC9612084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9E2B6EDFF; Tue, 4 Feb 2020 09:11:42 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 395F96EDFF; Tue, 4 Feb 2020 09:11:42 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 01:11:41 -0800 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="224233261" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 01:11:39 -0800 From: Jani Nikula To: Pankaj Bharadiya , daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v5 00/21] drm: Introduce struct drm_device based WARN* and use them in i915 In-Reply-To: <20200128181603.27767-1-pankaj.laxminarayan.bharadiya@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200128181603.27767-1-pankaj.laxminarayan.bharadiya@intel.com> Date: Tue, 04 Feb 2020 11:11:36 +0200 Message-ID: <87r1za3eev.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pankaj.laxminarayan.bharadiya@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 28 Jan 2020, Pankaj Bharadiya wrote: > Device specific dev_WARN and dev_WARN_ONCE macros available in kernel > include device information in the backtrace, so we know what device > the warnings originate from. > > Similar to this, add new struct drm_device based drm_WARN* macros. These > macros include device information in the backtrace, so we know > what device the warnings originate from. Knowing the device specific > information in the backtrace would be helpful in development all > around. > > This patch series aims to convert calls of WARN(), WARN_ON(), > WARN_ONCE() and WARN_ON_ONCE() in i915 driver to use the drm > device-specific variants automatically wherever struct device pointer > is available. > > To do this, this patch series - > - introduces new struct drm_device based WARN* macros > - automatically converts WARN* with device specific dev_WARN* > variants using coccinelle semantic patch scripts. > > The goal is to convert all the calls of WARN* with drm_WARN* in i915, > but there are still cases where device pointer is not readily > available in some functions (or I missed them somehow) using WARN* > hence some manual churning is needed. Handle such remaining cases > separately later. Thanks for the patches, pushed all that applied, please rebase the rest. BR, Jani. > > changes since v4: > - Address Jani's comment > - split major i915/display related conversions per file into > seperate patches so that non conflicting patches can be > merged. > > changes since v3: > - rebase pending unmerged patches on drm-tip > (bc626bbb5b6e drm-tip: 2020y-01m-25d-14h-28m-41s UTC integration manifest) > > changes since v2: > - rebase pending unmerged patches on drm-tip > > changes since v1: > - Address Jani's review comments > - Fix typo in comment of patch 0001 > - Get rid of helper functions > - Split patches by directory > > Changes since RFC at [1] > - Introduce drm_WARN* macros and use them as suggested by Sam and Jani > - Get rid of extra local variables > > [1] https://patchwork.freedesktop.org/series/71668/ > > > Pankaj Bharadiya (21): > drm/i915/display/icl_dsi: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/audio: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/cdclk: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/crt: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/ddi: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/display: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/power: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/dp: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/dpll_mgr: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/fbc: Make WARN* drm specific where drm_priv ptr is available > drm/i915/fbdev: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/hdcp: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/hdmi: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/overlay: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/panel: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/psr: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/sdvo: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/tc: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display: Make WARN* drm specific where drm_device ptr is available > drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available > drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available > > drivers/gpu/drm/i915/display/icl_dsi.c | 14 +- > drivers/gpu/drm/i915/display/intel_atomic.c | 6 +- > drivers/gpu/drm/i915/display/intel_audio.c | 19 +- > drivers/gpu/drm/i915/display/intel_bios.c | 10 +- > drivers/gpu/drm/i915/display/intel_bw.c | 3 +- > drivers/gpu/drm/i915/display/intel_cdclk.c | 81 ++++--- > drivers/gpu/drm/i915/display/intel_color.c | 3 +- > .../gpu/drm/i915/display/intel_combo_phy.c | 2 +- > .../gpu/drm/i915/display/intel_connector.c | 3 +- > drivers/gpu/drm/i915/display/intel_crt.c | 10 +- > drivers/gpu/drm/i915/display/intel_ddi.c | 92 +++---- > drivers/gpu/drm/i915/display/intel_display.c | 226 ++++++++++-------- > .../drm/i915/display/intel_display_power.c | 168 +++++++------ > drivers/gpu/drm/i915/display/intel_dp.c | 117 +++++---- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +- > drivers/gpu/drm/i915/display/intel_dpio_phy.c | 3 +- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 37 +-- > drivers/gpu/drm/i915/display/intel_dsb.c | 6 +- > .../i915/display/intel_dsi_dcs_backlight.c | 2 +- > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 +- > drivers/gpu/drm/i915/display/intel_fbc.c | 23 +- > drivers/gpu/drm/i915/display/intel_fbdev.c | 13 +- > drivers/gpu/drm/i915/display/intel_gmbus.c | 3 +- > drivers/gpu/drm/i915/display/intel_hdcp.c | 21 +- > drivers/gpu/drm/i915/display/intel_hdmi.c | 52 ++-- > drivers/gpu/drm/i915/display/intel_hotplug.c | 7 +- > .../gpu/drm/i915/display/intel_lpe_audio.c | 2 +- > drivers/gpu/drm/i915/display/intel_lvds.c | 7 +- > drivers/gpu/drm/i915/display/intel_opregion.c | 7 +- > drivers/gpu/drm/i915/display/intel_overlay.c | 12 +- > drivers/gpu/drm/i915/display/intel_panel.c | 19 +- > drivers/gpu/drm/i915/display/intel_pipe_crc.c | 7 +- > drivers/gpu/drm/i915/display/intel_psr.c | 32 +-- > drivers/gpu/drm/i915/display/intel_sdvo.c | 14 +- > drivers/gpu/drm/i915/display/intel_sprite.c | 5 +- > drivers/gpu/drm/i915/display/intel_tc.c | 18 +- > drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +- > drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +- > drivers/gpu/drm/i915/gvt/aperture_gm.c | 6 +- > drivers/gpu/drm/i915/gvt/cfg_space.c | 23 +- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 +- > drivers/gpu/drm/i915/gvt/display.c | 6 +- > drivers/gpu/drm/i915/gvt/dmabuf.c | 4 +- > drivers/gpu/drm/i915/gvt/edid.c | 19 +- > drivers/gpu/drm/i915/gvt/gtt.c | 21 +- > drivers/gpu/drm/i915/gvt/gvt.c | 4 +- > drivers/gpu/drm/i915/gvt/handlers.c | 22 +- > drivers/gpu/drm/i915/gvt/interrupt.c | 16 +- > drivers/gpu/drm/i915/gvt/kvmgt.c | 10 +- > drivers/gpu/drm/i915/gvt/mmio.c | 30 ++- > drivers/gpu/drm/i915/gvt/mmio_context.c | 8 +- > drivers/gpu/drm/i915/gvt/scheduler.c | 6 +- > drivers/gpu/drm/i915/gvt/vgpu.c | 6 +- > 53 files changed, 716 insertions(+), 532 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74ADAC2D0B1 for ; Tue, 4 Feb 2020 09:11:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FD702084E for ; Tue, 4 Feb 2020 09:11:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FD702084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E68E46EE02; Tue, 4 Feb 2020 09:11:42 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 395F96EDFF; Tue, 4 Feb 2020 09:11:42 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 01:11:41 -0800 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="224233261" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 01:11:39 -0800 From: Jani Nikula To: Pankaj Bharadiya , daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org In-Reply-To: <20200128181603.27767-1-pankaj.laxminarayan.bharadiya@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200128181603.27767-1-pankaj.laxminarayan.bharadiya@intel.com> Date: Tue, 04 Feb 2020 11:11:36 +0200 Message-ID: <87r1za3eev.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v5 00/21] drm: Introduce struct drm_device based WARN* and use them in i915 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 28 Jan 2020, Pankaj Bharadiya wrote: > Device specific dev_WARN and dev_WARN_ONCE macros available in kernel > include device information in the backtrace, so we know what device > the warnings originate from. > > Similar to this, add new struct drm_device based drm_WARN* macros. These > macros include device information in the backtrace, so we know > what device the warnings originate from. Knowing the device specific > information in the backtrace would be helpful in development all > around. > > This patch series aims to convert calls of WARN(), WARN_ON(), > WARN_ONCE() and WARN_ON_ONCE() in i915 driver to use the drm > device-specific variants automatically wherever struct device pointer > is available. > > To do this, this patch series - > - introduces new struct drm_device based WARN* macros > - automatically converts WARN* with device specific dev_WARN* > variants using coccinelle semantic patch scripts. > > The goal is to convert all the calls of WARN* with drm_WARN* in i915, > but there are still cases where device pointer is not readily > available in some functions (or I missed them somehow) using WARN* > hence some manual churning is needed. Handle such remaining cases > separately later. Thanks for the patches, pushed all that applied, please rebase the rest. BR, Jani. > > changes since v4: > - Address Jani's comment > - split major i915/display related conversions per file into > seperate patches so that non conflicting patches can be > merged. > > changes since v3: > - rebase pending unmerged patches on drm-tip > (bc626bbb5b6e drm-tip: 2020y-01m-25d-14h-28m-41s UTC integration manifest) > > changes since v2: > - rebase pending unmerged patches on drm-tip > > changes since v1: > - Address Jani's review comments > - Fix typo in comment of patch 0001 > - Get rid of helper functions > - Split patches by directory > > Changes since RFC at [1] > - Introduce drm_WARN* macros and use them as suggested by Sam and Jani > - Get rid of extra local variables > > [1] https://patchwork.freedesktop.org/series/71668/ > > > Pankaj Bharadiya (21): > drm/i915/display/icl_dsi: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/audio: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/cdclk: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/crt: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/ddi: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/display: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/power: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/dp: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/dpll_mgr: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/fbc: Make WARN* drm specific where drm_priv ptr is available > drm/i915/fbdev: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/hdcp: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/hdmi: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/overlay: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/panel: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/psr: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/sdvo: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/tc: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display: Make WARN* drm specific where drm_device ptr is available > drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available > drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available > > drivers/gpu/drm/i915/display/icl_dsi.c | 14 +- > drivers/gpu/drm/i915/display/intel_atomic.c | 6 +- > drivers/gpu/drm/i915/display/intel_audio.c | 19 +- > drivers/gpu/drm/i915/display/intel_bios.c | 10 +- > drivers/gpu/drm/i915/display/intel_bw.c | 3 +- > drivers/gpu/drm/i915/display/intel_cdclk.c | 81 ++++--- > drivers/gpu/drm/i915/display/intel_color.c | 3 +- > .../gpu/drm/i915/display/intel_combo_phy.c | 2 +- > .../gpu/drm/i915/display/intel_connector.c | 3 +- > drivers/gpu/drm/i915/display/intel_crt.c | 10 +- > drivers/gpu/drm/i915/display/intel_ddi.c | 92 +++---- > drivers/gpu/drm/i915/display/intel_display.c | 226 ++++++++++-------- > .../drm/i915/display/intel_display_power.c | 168 +++++++------ > drivers/gpu/drm/i915/display/intel_dp.c | 117 +++++---- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +- > drivers/gpu/drm/i915/display/intel_dpio_phy.c | 3 +- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 37 +-- > drivers/gpu/drm/i915/display/intel_dsb.c | 6 +- > .../i915/display/intel_dsi_dcs_backlight.c | 2 +- > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 +- > drivers/gpu/drm/i915/display/intel_fbc.c | 23 +- > drivers/gpu/drm/i915/display/intel_fbdev.c | 13 +- > drivers/gpu/drm/i915/display/intel_gmbus.c | 3 +- > drivers/gpu/drm/i915/display/intel_hdcp.c | 21 +- > drivers/gpu/drm/i915/display/intel_hdmi.c | 52 ++-- > drivers/gpu/drm/i915/display/intel_hotplug.c | 7 +- > .../gpu/drm/i915/display/intel_lpe_audio.c | 2 +- > drivers/gpu/drm/i915/display/intel_lvds.c | 7 +- > drivers/gpu/drm/i915/display/intel_opregion.c | 7 +- > drivers/gpu/drm/i915/display/intel_overlay.c | 12 +- > drivers/gpu/drm/i915/display/intel_panel.c | 19 +- > drivers/gpu/drm/i915/display/intel_pipe_crc.c | 7 +- > drivers/gpu/drm/i915/display/intel_psr.c | 32 +-- > drivers/gpu/drm/i915/display/intel_sdvo.c | 14 +- > drivers/gpu/drm/i915/display/intel_sprite.c | 5 +- > drivers/gpu/drm/i915/display/intel_tc.c | 18 +- > drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +- > drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +- > drivers/gpu/drm/i915/gvt/aperture_gm.c | 6 +- > drivers/gpu/drm/i915/gvt/cfg_space.c | 23 +- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 +- > drivers/gpu/drm/i915/gvt/display.c | 6 +- > drivers/gpu/drm/i915/gvt/dmabuf.c | 4 +- > drivers/gpu/drm/i915/gvt/edid.c | 19 +- > drivers/gpu/drm/i915/gvt/gtt.c | 21 +- > drivers/gpu/drm/i915/gvt/gvt.c | 4 +- > drivers/gpu/drm/i915/gvt/handlers.c | 22 +- > drivers/gpu/drm/i915/gvt/interrupt.c | 16 +- > drivers/gpu/drm/i915/gvt/kvmgt.c | 10 +- > drivers/gpu/drm/i915/gvt/mmio.c | 30 ++- > drivers/gpu/drm/i915/gvt/mmio_context.c | 8 +- > drivers/gpu/drm/i915/gvt/scheduler.c | 6 +- > drivers/gpu/drm/i915/gvt/vgpu.c | 6 +- > 53 files changed, 716 insertions(+), 532 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx