All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, i@maskray.me, philmd@redhat.com
Subject: Re: [PATCH v2 3/7] configure: Do not force pie=no for non-x86
Date: Tue, 07 Jan 2020 12:58:56 +0000	[thread overview]
Message-ID: <87r20b4e3z.fsf@linaro.org> (raw)
In-Reply-To: <20191218223441.23852-4-richard.henderson@linaro.org>


Richard Henderson <richard.henderson@linaro.org> writes:

> PIE is supported on many other hosts besides x86.
>
> The default for non-x86 is now the same as x86: pie is used
> if supported, and may be forced via --enable/--disable-pie.
>
> The original commit (40d6444e91c) said:
>
>   "Non-x86 are not changed, as they require TCG changes"
>
> but I think that's wrong -- there's nothing about PIE that
> affects TCG one way or another.
>
> Tested on aarch64 (bionic) and ppc64le (centos 7) hosts.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Also I double checked OpenBSD still worked:

Tested-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  configure | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/configure b/configure
> index 30e3875c6b..99faf64a74 100755
> --- a/configure
> +++ b/configure
> @@ -2018,16 +2018,6 @@ if ! compile_prog "-Werror" "" ; then
>  	"Thread-Local Storage (TLS). Please upgrade to a version that does."
>  fi
>  
> -if test "$pie" = ""; then
> -  case "$cpu-$targetos" in
> -    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
> -      ;;
> -    *)
> -      pie="no"
> -      ;;
> -  esac
> -fi
> -
>  if test "$pie" != "no" ; then
>    cat > $TMPC << EOF


-- 
Alex Bennée


  parent reply	other threads:[~2020-01-07 14:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 22:34 [PATCH v2 0/7] configure: Improve PIE and other linkage Richard Henderson
2019-12-18 22:34 ` [PATCH v2 1/7] configure: Drop adjustment of textseg Richard Henderson
2020-01-07 11:34   ` Alex Bennée
2019-12-18 22:34 ` [PATCH v2 2/7] tcg: Remove softmmu code_gen_buffer fixed address Richard Henderson
2020-01-07 11:35   ` Alex Bennée
2019-12-18 22:34 ` [PATCH v2 3/7] configure: Do not force pie=no for non-x86 Richard Henderson
2020-01-07 11:37   ` Philippe Mathieu-Daudé
2020-01-07 12:58   ` Alex Bennée [this message]
2019-12-18 22:34 ` [PATCH v2 4/7] configure: Always detect -no-pie toolchain support Richard Henderson
2020-01-07 13:16   ` Alex Bennée
2020-01-08  0:45     ` Richard Henderson
2019-12-18 22:34 ` [PATCH v2 5/7] configure: Unnest detection of -z,relro and -z,now Richard Henderson
2019-12-18 22:46   ` [PATCH v2 5/7] configure: Unnest detection of -z, relro and -z, now Philippe Mathieu-Daudé
2019-12-19  7:11     ` Fangrui Song
2020-01-07 13:18   ` Alex Bennée
2019-12-18 22:34 ` [PATCH v2 6/7] configure: Override the os default with --disable-pie Richard Henderson
2020-01-07 13:24   ` Alex Bennée
2019-12-18 22:34 ` [PATCH v2 7/7] configure: Support -static-pie if requested Richard Henderson
2020-01-07 13:45   ` Alex Bennée
2020-01-06  2:57 ` [PATCH v2 0/7] configure: Improve PIE and other linkage Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r20b4e3z.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=i@maskray.me \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.