From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshinori Sato Date: Mon, 16 Dec 2019 11:28:01 +0000 Subject: Re: [PATCH] sh: add missing EXPORT_SYMBOL() for __delay Message-Id: <87r214fr26.wl-ysato@users.sourceforge.jp> List-Id: References: <87wob2clos.wl-kuninori.morimoto.gx@renesas.com> In-Reply-To: <87wob2clos.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kuninori Morimoto Cc: Rich Felker , Andrew Morton , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org On Thu, 12 Dec 2019 11:38:43 +0900, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > __delay() is used from kernel module. > We need EXPORT_SYMBOL(), otherwise we will get compile error. > > ERROR: "__delay" [drivers/net/phy/mdio-cavium.ko] undefined! > > Signed-off-by: Kuninori Morimoto > --- > arch/sh/lib/delay.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/sh/lib/delay.c b/arch/sh/lib/delay.c > index dad8e6a..540e670 100644 > --- a/arch/sh/lib/delay.c > +++ b/arch/sh/lib/delay.c > @@ -29,6 +29,7 @@ void __delay(unsigned long loops) > : "0" (loops) > : "t"); > } > +EXPORT_SYMBOL(__delay); > > inline void __const_udelay(unsigned long xloops) > { > -- > 2.7.4 > Applied sh-next. Thanks. -- Yosinori Sato From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 107E3C43603 for ; Mon, 16 Dec 2019 11:28:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8341206D3 for ; Mon, 16 Dec 2019 11:28:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727380AbfLPL2J (ORCPT ); Mon, 16 Dec 2019 06:28:09 -0500 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:53832 "EHLO mail02.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbfLPL2J (ORCPT ); Mon, 16 Dec 2019 06:28:09 -0500 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id C0A4F99C3B; Mon, 16 Dec 2019 20:28:07 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 07B3624008E; Mon, 16 Dec 2019 20:28:07 +0900 (JST) Date: Mon, 16 Dec 2019 20:28:01 +0900 Message-ID: <87r214fr26.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Kuninori Morimoto Cc: Rich Felker , Andrew Morton , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sh: add missing EXPORT_SYMBOL() for __delay In-Reply-To: <87wob2clos.wl-kuninori.morimoto.gx@renesas.com> References: <87wob2clos.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Dec 2019 11:38:43 +0900, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > __delay() is used from kernel module. > We need EXPORT_SYMBOL(), otherwise we will get compile error. > > ERROR: "__delay" [drivers/net/phy/mdio-cavium.ko] undefined! > > Signed-off-by: Kuninori Morimoto > --- > arch/sh/lib/delay.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/sh/lib/delay.c b/arch/sh/lib/delay.c > index dad8e6a..540e670 100644 > --- a/arch/sh/lib/delay.c > +++ b/arch/sh/lib/delay.c > @@ -29,6 +29,7 @@ void __delay(unsigned long loops) > : "0" (loops) > : "t"); > } > +EXPORT_SYMBOL(__delay); > > inline void __const_udelay(unsigned long xloops) > { > -- > 2.7.4 > Applied sh-next. Thanks. -- Yosinori Sato