From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/7] target/alpha: Use array for FPCR_DYN conversion
Date: Mon, 23 Sep 2019 17:23:35 +0100 [thread overview]
Message-ID: <87r247asmw.fsf@linaro.org> (raw)
In-Reply-To: <20190921043256.4575-2-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> This is a bit more straight-forward than using a switch statement.
> No functional change.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/alpha/helper.c | 24 ++++++++----------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/target/alpha/helper.c b/target/alpha/helper.c
> index 19cda0a2db..6c1703682e 100644
> --- a/target/alpha/helper.c
> +++ b/target/alpha/helper.c
> @@ -36,6 +36,13 @@ uint64_t cpu_alpha_load_fpcr(CPUAlphaState *env)
>
> void cpu_alpha_store_fpcr(CPUAlphaState *env, uint64_t val)
> {
> + static const uint8_t rm_map[] = {
> + [FPCR_DYN_NORMAL >> FPCR_DYN_SHIFT] = float_round_nearest_even,
> + [FPCR_DYN_CHOPPED >> FPCR_DYN_SHIFT] = float_round_to_zero,
> + [FPCR_DYN_MINUS >> FPCR_DYN_SHIFT] = float_round_down,
> + [FPCR_DYN_PLUS >> FPCR_DYN_SHIFT] = float_round_up,
> + };
> +
> uint32_t fpcr = val >> 32;
> uint32_t t = 0;
>
> @@ -48,22 +55,7 @@ void cpu_alpha_store_fpcr(CPUAlphaState *env, uint64_t val)
> env->fpcr = fpcr;
> env->fpcr_exc_enable = ~t & FPCR_STATUS_MASK;
>
> - switch (fpcr & FPCR_DYN_MASK) {
> - case FPCR_DYN_NORMAL:
> - default:
> - t = float_round_nearest_even;
> - break;
> - case FPCR_DYN_CHOPPED:
> - t = float_round_to_zero;
> - break;
> - case FPCR_DYN_MINUS:
> - t = float_round_down;
> - break;
> - case FPCR_DYN_PLUS:
> - t = float_round_up;
> - break;
> - }
> - env->fpcr_dyn_round = t;
> + env->fpcr_dyn_round = rm_map[(fpcr & FPCR_DYN_MASK) >> FPCR_DYN_SHIFT];
>
> env->fpcr_flush_to_zero = (fpcr & FPCR_UNFD) && (fpcr & FPCR_UNDZ);
> env->fp_status.flush_inputs_to_zero = (fpcr & FPCR_DNZ) != 0;
--
Alex Bennée
next prev parent reply other threads:[~2019-09-23 16:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 4:32 [PATCH 0/7] target/alpha: Fix linux-user exception for CVTTQ Richard Henderson
2019-09-21 4:32 ` [PATCH 1/7] target/alpha: Use array for FPCR_DYN conversion Richard Henderson
2019-09-21 8:53 ` Philippe Mathieu-Daudé
2019-09-23 16:23 ` Alex Bennée [this message]
2019-09-21 4:32 ` [PATCH 2/7] target/alpha: Fix SWCR_MAP_UMZ Richard Henderson
2019-09-23 16:33 ` Alex Bennée
2019-09-21 4:32 ` [PATCH 3/7] target/alpha: Fix SWCR_TRAP_ENABLE_MASK Richard Henderson
2019-09-21 4:32 ` [PATCH 4/7] target/alpha: Handle SWCR_MAP_DMZ earlier Richard Henderson
2019-09-21 4:32 ` [PATCH 5/7] target/alpha: Write to fpcr_flush_to_zero once Richard Henderson
2019-09-21 8:54 ` Philippe Mathieu-Daudé
2019-09-23 16:38 ` Alex Bennée
2019-09-21 4:32 ` [PATCH 6/7] target/alpha: Mask IOV exception with INV for user-only Richard Henderson
2019-09-23 16:39 ` Alex Bennée
2019-09-21 4:32 ` [PATCH 7/7] target/alpha: Tidy helper_fp_exc_raise_s Richard Henderson
2019-09-21 8:57 ` Philippe Mathieu-Daudé
2019-09-23 16:40 ` Alex Bennée
2019-09-23 16:44 ` [PATCH 0/7] target/alpha: Fix linux-user exception for CVTTQ Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r247asmw.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.