From: Felipe Balbi <balbi@kernel.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ladislav Michl <ladis@linux-mips.org>
Subject: Re: [PATCH v5 2/6] usb: gadget: u_serial: reimplement console support
Date: Fri, 09 Aug 2019 15:05:55 +0300 [thread overview]
Message-ID: <87r25utufw.fsf@gmail.com> (raw)
In-Reply-To: <0dd7dc4d5135b838d8f0fe98d0a689163cc9dda8.1563809035.git.mirq-linux@rere.qmqm.pl>
Hi,
Michał Mirosław <mirq-linux@rere.qmqm.pl> writes:
> Rewrite console support to fix a few shortcomings of the old code
> preventing its use with multiple ports. This removes some duplicated
> code and replaces a custom kthread with simpler workqueue item.
>
> Only port ttyGS0 gets to be a console for now.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Tested-by: Ladislav Michl <ladis@linux-mips.org>
checking file drivers/usb/gadget/function/u_serial.c
Hunk #7 FAILED at 1206.
Hunk #8 succeeded at 1302 (offset -2 lines).
Hunk #9 succeeded at 1334 (offset -2 lines).
Hunk #10 succeeded at 1363 (offset -2 lines).
1 out of 10 hunks FAILED
Could you rebase on my testing/next?
--
balbi
next prev parent reply other threads:[~2019-08-09 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 15:26 [PATCH v5 0/6] usb: gadget: u_serial: console improvements Michał Mirosław
2019-07-22 15:26 ` [PATCH v5 1/6] usb: gadget: u_serial: add missing port entry locking Michał Mirosław
2019-07-22 15:26 ` [PATCH v5 2/6] usb: gadget: u_serial: reimplement console support Michał Mirosław
2019-07-23 2:18 ` Baolin Wang
2019-07-23 8:15 ` Ladislav Michl
2019-07-23 12:06 ` Michał Mirosław
2019-08-09 12:05 ` Felipe Balbi [this message]
2019-08-10 8:11 ` Michał Mirosław
2019-09-11 10:05 ` Ladislav Michl
2019-07-22 15:26 ` [PATCH v5 3/6] usb: gadget: u_serial: make OBEX port not a console Michał Mirosław
2019-07-22 15:26 ` [PATCH v5 4/6] usb: gadget: u_serial: allow more console gadget ports Michał Mirosław
2019-07-22 15:26 ` [PATCH v5 5/6] usb: gadget: u_serial: diagnose missed console messages Michał Mirosław
2019-07-22 15:26 ` [PATCH v5 6/6] usb: gadget: legacy/serial: allow dynamic removal Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r25utufw.fsf@gmail.com \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ladis@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.