From: Eric Anholt <eric@anholt.net>
To: Annaliese McDermond <nh6z@nh6z.net>, Wolfram Sang <wsa@the-dreams.de>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
swarren@wwwdotorg.org, NWDR Team <team@nwdigitalradio.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c: bcm2835: Model Divider in CCF
Date: Tue, 28 May 2019 15:25:53 -0700 [thread overview]
Message-ID: <87r28ijjwu.fsf@anholt.net> (raw)
In-Reply-To: <E711B8C3-85B8-435C-97FD-E62BCB88B679@nh6z.net>
[-- Attachment #1.1: Type: text/plain, Size: 954 bytes --]
Annaliese McDermond <nh6z@nh6z.net> writes:
>> On May 27, 2019, at 12:15 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>
>> Regardless which solution is favoured, I am going to apply this patch in
>> a minute:
>>
>> http://patchwork.ozlabs.org/patch/1097688/
>>
>> It enables this driver for ARCH_BRCMSTB. So, the solution should work
>> for this as well. (I don't know any of these platforms well)
>
> I did some looking the other day, and I had forgotten that the RPi has 3
> of the i2c-bcm2835 devices each with their own divider that sits in their
> register space. This makes me think the correct solution would be for
> the divider to be controlled in the driver as was in my original patch.
> Otherwise we’d have to make three different dividers in the bcm2835-clk
> driver, and the i2c driver would no longer work for other platforms.
Control of the divider should definitely be in the i2c driver, not in
clk-bcm2835.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-28 22:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 7:12 [PATCH v2] i2c: bcm2835: Model Divider in CCF Annaliese McDermond
2019-05-08 7:12 ` Annaliese McDermond
2019-05-16 5:37 ` Annaliese McDermond
2019-05-16 7:58 ` Wolfram Sang
2019-05-17 1:55 ` Annaliese McDermond
2019-05-27 19:15 ` Wolfram Sang
2019-05-27 20:00 ` Annaliese McDermond
2019-05-27 20:20 ` Wolfram Sang
2019-05-28 22:25 ` Eric Anholt [this message]
2019-05-16 10:59 ` Stefan Wahren
2019-05-16 10:59 ` Stefan Wahren
2019-05-28 7:52 ` Stefan Wahren
2019-05-28 7:52 ` Stefan Wahren
2019-05-29 3:01 ` Annaliese McDermond
2019-05-29 4:32 ` Annaliese McDermond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r28ijjwu.fsf@anholt.net \
--to=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nh6z@nh6z.net \
--cc=stefan.wahren@i2se.com \
--cc=swarren@wwwdotorg.org \
--cc=team@nwdigitalradio.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.