From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Souza, Jose" <jose.souza@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 00/17] drm/i915: switch to kernel fixed size types
Date: Thu, 17 Jan 2019 09:29:26 +0200 [thread overview]
Message-ID: <87r2dbg2sp.fsf@intel.com> (raw)
In-Reply-To: <20190116170504.GQ20097@intel.com>
On Wed, 16 Jan 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Jan 16, 2019 at 11:15:18AM +0200, Jani Nikula wrote:
>> Hi all -
>>
>> I haven't cared all that much about using C99 fixed size types (uint32_t
>> etc.) in the driver in addition to kernel types, as long as only one or
>> the other is used in the same struct/function/file. But the increasing
>> mixed use crossed some OCD threshold the other day. It gets ugly, and
>> sets a precedent that mixed use is fine.
>>
>> Let's switch to kernel types exclusively, shall we?
>>
>> Each path in the series is independent of the others, and it's mostly
>> one patch per file, apart from the first patch which gathers all the
>> isolated uses into one patch. I've tried to order the series from least
>> to most likely to cause conflicts with in-flight work per gut feeling.
>>
>> Please holler if you think some of these patches need to wait for some
>> other, more important stuff to land first. This was mostly scripted,
>> with a few manual edits on top, so pretty quick to redo on top later.
>>
>> After most of these have landed, I intend to drop PREFER_KERNEL_TYPES
>> from the checkpatch ignore list, and enforce.
>
> Did a really quick scan through and the pattern matcher in the
> brain didn't complain, so seems good enough to me.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks for the reviews Chris, Ville & José! I pushed the the patches
listed below for starters. Started small.
While I took care with the r-b's, I failed to record the acks from Chris
and Tvrtko. :( Apologies.
BR,
Jani.
Pushed now:
>> drm/i915: small isolated c99 types to kernel types switch
>> drm/i915/crt: switch to kernel types
>> drm/i915/lspcon: switch to kernel types
>> drm/i915/debugfs: switch to kernel types
>> drm/i915/irq: switch to kernel types
>> drm/i915/cdclk: switch to kernel types
>> drm/i915/dpll_mgr: switch to kernel types
>> drm/i915/dp: switch to kernel types
>> drm/i915/sprite: switch to kernel types
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-01-17 7:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 9:15 [PATCH 00/17] drm/i915: switch to kernel fixed size types Jani Nikula
2019-01-16 9:15 ` [PATCH 01/17] drm/i915: small isolated c99 types to kernel types switch Jani Nikula
2019-01-16 9:17 ` Chris Wilson
2019-01-17 0:27 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 02/17] drm/i915/crt: switch to kernel types Jani Nikula
2019-01-17 0:19 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 03/17] drm/i915/sdvo: " Jani Nikula
2019-01-17 0:21 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 04/17] drm/i915/lspcon: " Jani Nikula
2019-01-17 0:28 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 05/17] drm/i915/debugfs: " Jani Nikula
2019-01-17 0:29 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 06/17] drm/i915/irq: " Jani Nikula
2019-01-16 9:19 ` Chris Wilson
2019-01-17 0:32 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 07/17] drm/i915/cdclk: " Jani Nikula
2019-01-17 0:34 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 08/17] drm/i915/dpll_mgr: " Jani Nikula
2019-01-17 0:41 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 09/17] drm/i915/dp: " Jani Nikula
2019-01-17 0:53 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 10/17] drm/i915/sprite: " Jani Nikula
2019-01-17 0:55 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 11/17] drm/i915/color: " Jani Nikula
2019-01-17 0:58 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 12/17] drm/i915/pm: " Jani Nikula
2019-01-17 1:06 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 13/17] drm/i915/ddi: " Jani Nikula
2019-01-17 1:07 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 14/17] drm/i915/csr: " Jani Nikula
2019-01-16 17:03 ` Ville Syrjälä
2019-01-17 1:11 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 15/17] drm/i915/display: " Jani Nikula
2019-01-17 1:14 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 16/17] drm/i915/i915_drv.h: " Jani Nikula
2019-01-16 9:21 ` Chris Wilson
2019-01-17 1:20 ` Souza, Jose
2019-01-16 9:15 ` [PATCH 17/17] drm/i915/intel_drv.h: " Jani Nikula
2019-01-17 1:23 ` Souza, Jose
2019-01-16 9:22 ` [PATCH 00/17] drm/i915: switch to kernel fixed size types Chris Wilson
2019-01-16 9:26 ` Tvrtko Ursulin
2019-01-16 10:54 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-01-16 11:34 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-16 14:37 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-16 17:05 ` [PATCH 00/17] " Ville Syrjälä
2019-01-17 7:29 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2dbg2sp.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.