From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVKRN-0003rn-As for qemu-devel@nongnu.org; Fri, 07 Dec 2018 13:01:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVKRM-0002E9-KY for qemu-devel@nongnu.org; Fri, 07 Dec 2018 13:01:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53320) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gVKRM-00029x-DO for qemu-devel@nongnu.org; Fri, 07 Dec 2018 13:01:28 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 17A533C2CCC for ; Fri, 7 Dec 2018 18:01:27 +0000 (UTC) From: Markus Armbruster References: <20181207161447.31314-1-philmd@redhat.com> Date: Fri, 07 Dec 2018 19:01:23 +0100 In-Reply-To: <20181207161447.31314-1-philmd@redhat.com> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Fri, 7 Dec 2018 17:14:47 +0100") Message-ID: <87r2etp66k.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] util/error: Remove an unnecessary NULL check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: "Daniel P . =?utf-8?Q?Berrang=C3=A9?=" , Thomas Huth , qemu-devel@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > This NULL check was required while introduced in 680d16dcb79f. > Later refactor added a NULL check in error_setv(), so this check > is now redundant. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Markus Armbruster