From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 2/2] drm: Revert syncobj timeline changes. Date: Thu, 15 Nov 2018 10:47:36 -0800 Message-ID: <87r2fmyy7r.fsf@anholt.net> References: <20181108160422.17743-1-eric@anholt.net> <20181108160422.17743-3-eric@anholt.net> <635caa27-eb0b-a4d6-5a1d-3fbe5382bd6b@amd.com> <87d0rex8h2.fsf@anholt.net> <87y3a1sx8t.fsf@anholt.net> <199c35bc-e684-fbc4-dcef-d7105d82f0ff@gmail.com> <7e92b072-9e3f-6567-523a-d3495a24f085@amd.com> <84df39ac-e8a2-f0f5-6562-f2df25c110e8@amd.com> <8736s4w31m.fsf@anholt.net> <22b7eef1-cc13-5662-5656-d39aeb0c78e0@amd.com> <87bm6rb0cy.fsf@anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1444459616==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 2ADAD6E625 for ; Thu, 15 Nov 2018 18:47:39 +0000 (UTC) In-Reply-To: <87bm6rb0cy.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Koenig, Christian" , "Zhou, David(ChunMing)" , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1444459616== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Eric Anholt writes: > [ Unknown signature status ] > "Koenig, Christian" writes: > >> Hi Eric, >> >> thanks for your time to test this. >> >> Am 14.11.18 um 08:07 schrieb Eric Anholt: >>> zhoucm1 writes: >>> >>>> Ping.. Eric, Could you help try attached patch for your memory issue? >>>> >>>> If you have no time, Could you tell me which tests you're using? Where >>>> can I get the test app? >>> You sent the patch yesterday. I burned 3 of the 4 days I worked last >>> week trying to track down this pile of regressions, and I had other >>> things I was supposed to be doing. My driver is *still* broken in >>> drm-misc-next. >> >> Including the revert? > > As far as I know? Today I worked on cleaning up my old igts so I'll > have automated tests of v3d gpu reset instead of a git stash of some > mesa hacks. Once that's ready I'll rebase onto drm-misc-next and try > again, hopefully tomorrow. OK, got the igts working. My test is: Submit hanging job Submit non-hanging job Wait on non-hanging job. With patch 1/2 in place, recovery works -- the wait returns after 2 seconds. With patch 1/2 removed, the test never completes, and a ^C produces: [ 96.795892] ------------[ cut here ]------------ [ 96.795932] WARNING: CPU: 3 PID: 3149 at drivers/dma-buf/dma-fence.c:225 dma_fence_release+0xfc/0x1b0 [ 96.795937] Modules linked in: [ 96.795948] CPU: 3 PID: 3149 Comm: v3d_cl_hang Not tainted 4.20.0-rc1+ #497 [ 96.795953] Hardware name: Broadcom STB (Flattened Device Tree) [ 96.795971] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 96.795984] [] (show_stack) from [] (dump_stack+0xa8/0xd4) [ 96.795997] [] (dump_stack) from [] (__warn.part.3+0xbc/0xec) [ 96.796005] [] (__warn.part.3) from [] (warn_slowpath_null+0x44/0x4c) [ 96.796012] [] (warn_slowpath_null) from [] (dma_fence_release+0xfc/0x1b0) [ 96.796024] [] (dma_fence_release) from [] (drm_sched_fence_release_scheduled+0x64/0x68) [ 96.796032] [] (drm_sched_fence_release_scheduled) from [] (drm_sched_entity_fini+0x1e4/0x1e8) [ 96.796042] [] (drm_sched_entity_fini) from [] (v3d_postclose+0x18/0x2c) [ 96.796055] [] (v3d_postclose) from [] (drm_file_free.part.0+0x1e8/0x2c0) [ 96.796064] [] (drm_file_free.part.0) from [] (drm_release+0x8c/0x108) [ 96.796074] [] (drm_release) from [] (__fput+0xa4/0x1e4) [ 96.796083] [] (__fput) from [] (task_work_run+0x9c/0xd0) [ 96.796092] [] (task_work_run) from [] (do_exit+0x474/0xbf0) [ 96.796099] [] (do_exit) from [] (do_group_exit+0x3c/0xbc) [ 96.796111] [] (do_group_exit) from [] (get_signal+0x250/0x9f4) [ 96.796118] [] (get_signal) from [] (do_work_pending+0x118/0x5f8) [ 96.796126] [] (do_work_pending) from [] (slow_work_pending+0xc/0x20) [ 96.796131] Exception stack(0xe90f7fb0 to 0xe90f7ff8) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlvtv0gACgkQtdYpNtH8 nuhzPQ//dB9fdO47+DiHR+DvcGMCThCaelFx7nGSnDYBHTGcN8yepotwcF5pN8Ps hgIEOiuEt89+K6yrNEuwLqs+eY6GVKLw/IsuBi9wI4IDDY/1tl1gmxq6UCRkhS9n aWy1ZmXwMgVzlccKFQ7RhT7EwcK2S8ukACb2GmRpV++gDXDDy8ANtA3MNvwjjzbf wEJE9ko/4JX3RONy7OXslkKQjKKQvK5lkW3jRNN2+nu5ryQ+5vrWwgr5pVvhEXuu YTqnB6N4C5SQRIp//zhNdO2RnI32wqt3aC3IzmqpntEGZtoyQDxWS2zCAnXDx+G/ UWN8kv0UucMO+1k8q8D5IRxqvanKptjYclVltLHB27u5r1/Rn82tptTN9Txiz9uT Hhcm+vXp8h39n4alIJmbo/n749Vo5gaQtoKZ9aQqSz19TEvej1g/3gX7dcCMgkO+ jv2qHJgVETTq50D05EK8gRLpRCspDe9UbNy+V21BFqcHOSjNUUKqrSx2clk4d9pb OB4Jl3MlGgcBH1B5RPYu4Wpgw3J1Gav8vccx/GpsqSCGkza+CRPWNQvigNJ6BF+m RTK9lj01auQlfkW4QxGsWOnMn2YHG1wTfXdSYVMmtyXAqWiuaqQAFl3Z190oQeKy Sg1voj/tZ9bsRR4SS1TYxFzDMN3jfh7uc/s/iy+sEiItxASnGvA= =Bmbn -----END PGP SIGNATURE----- --=-=-=-- --===============1444459616== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1444459616==--