From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Rip Route" <riproute@gmail.com>,
"Arend Van Spriel" <arend.vanspriel@broadcom.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
"Wright Feng" <wright.feng@cypress.com>,
"David Miller" <davem@davemloft.net>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Chung-Hsien Hsu" <stanley.hsu@cypress.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER
<brcm80211-dev-list.pdl@broadcom.com>,"
<brcm80211-dev-list.pdl@broadcom.com>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER
<brcm80211-dev-list.pdl@broadcom.com>,"
<brcm80211-dev-list@cypress.com>, "Dan HAAB" <dan.haab@luxul.com>
Subject: Re: [PATCH] brcmfmac: support STA info struct v7
Date: Wed, 07 Nov 2018 12:02:48 +0200 [thread overview]
Message-ID: <87r2fxciif.fsf@codeaurora.org> (raw)
In-Reply-To: <CACna6rxJUxGLw1P7d4nCRocHxSs3nyxBvHzr4YaDH9ES+kg39g@mail.gmail.com> ("Rafał Miłecki"'s message of "Wed, 7 Nov 2018 10:46:23 +0100")
Rafał Miłecki <zajec5@gmail.com> writes:
> On Thu, 11 Oct 2018 at 22:21, Dan Haab <riproute@gmail.com> wrote:
>> The newest firmwares provide STA info using v7 of the struct. As v7
>> isn't backward compatible, a union is needed.
>>
>> Even though brcmfmac does not use any of the new info it's important to
>> provide the proper struct buffer. Without this change new firmwares will
>> fallback to the very limited v3 instead of something in between such as
>> v4.
>>
>> Signed-off-by: Dan Haab <dan.haab@luxul.com>
>
> It's too bad Broadcom's existing struct has been changed instead of
> just being extended.
>
> The patch looks good to me though. I just wanted to share my opinion /
> ping due to patch being marked as "Deferred".
>
> Reviewed-by: Rafał Miłecki <rafal@milecki.pl>
Good that you brought this up, I wasn't sure what to do with it so I
marked as Deferred. Arend, please let me know what I should do.
--
Kalle Valo
next prev parent reply other threads:[~2018-11-07 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 20:19 [PATCH] brcmfmac: support STA info struct v7 Dan Haab
2018-10-12 9:02 ` Arend van Spriel
2018-10-12 17:02 ` Rip Route
2018-11-07 9:46 ` Rafał Miłecki
2018-11-07 10:02 ` Kalle Valo [this message]
2018-11-07 21:00 ` Arend van Spriel
2018-11-07 21:03 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2fxciif.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=dan.haab@luxul.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=riproute@gmail.com \
--cc=stanley.hsu@cypress.com \
--cc=wright.feng@cypress.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.