From: Kalle Valo <kvalo@codeaurora.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: fix tx99 with monitor mode interface
Date: Mon, 20 Aug 2018 15:05:25 +0300 [thread overview]
Message-ID: <87r2itp7ju.fsf@codeaurora.org> (raw)
In-Reply-To: <20180820093751.63406-1-nbd@nbd.name> (Felix Fietkau's message of "Mon, 20 Aug 2018 11:37:51 +0200")
Felix Fietkau <nbd@nbd.name> writes:
> Tx99 is typically configured via a monitor mode interface, which does
> not get added to the driver as a vif. Since the code currently expects
> a configured virtual interface for tx99, enabling tx99 via debugfs fails.
> Since the vif is not needed anyway, remove all checks for it.
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
[...]
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -1251,15 +1251,10 @@ static int ath9k_add_interface(struct ieee80211_hw *hw,
> struct ath_vif *avp = (void *)vif->drv_priv;
> struct ath_node *an = &avp->mcast_node;
>
> - mutex_lock(&sc->mutex);
> + if (IS_ENABLED(CPTCFG_ATH9K_TX99))
> + return -EOPNOTSUPP;
Obviously this should be CONFIG_ATH9K_TX99, I'll fix that in the pending
branch.
--
Kalle Valo
next prev parent reply other threads:[~2018-08-20 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 9:37 [PATCH] ath9k: fix tx99 with monitor mode interface Felix Fietkau
2018-08-20 12:05 ` Kalle Valo [this message]
2018-08-20 12:07 ` Felix Fietkau
2018-08-28 13:46 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2itp7ju.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.