From: Juan Quintela <quintela@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Eric Blake" <eblake@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 5/8] tests: Skip old versioned machine types in quick testing mode
Date: Fri, 17 Aug 2018 12:33:27 +0200 [thread overview]
Message-ID: <87r2ixuvt4.fsf@trasno.org> (raw)
In-Reply-To: <1534419358-10932-6-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Thu, 16 Aug 2018 13:35:55 +0200")
Thomas Huth <thuth@redhat.com> wrote:
> The tests that check something for all machine types currently spend
> a lot of time checking old machine types (like "pc-i440fx-2.0" for
> example). The chances that we find something new there in addition
> to checking the latest version of a machine type are pretty low, so
> we should not waste the time of the developers by testing this again
> and again in the "quick" testing mode.
> Thus let's add some code to determine whether we are testing a current
> machine type or an old one, and only test the old types if we are
> running in "SPEED=slow" mode.
> This decreases the testing time quite a bit now, e.g. the qom-test
> now finishes within 4 seconds for qemu-system-x86_64 instead of 30
> seconds when testing all machines.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Thanks!!!!!
next prev parent reply other threads:[~2018-08-17 10:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 11:35 [Qemu-devel] [PATCH v2 0/8] Various qtest-related patches and a mc146818rtc fix Thomas Huth
2018-08-16 11:35 ` [Qemu-devel] [PATCH v2 1/8] tests/migration-test: Silence the kvm_hv message by default Thomas Huth
2018-08-17 10:26 ` Juan Quintela
2018-08-16 11:35 ` [Qemu-devel] [PATCH v2 2/8] net: Silence 'has no peer' messages in testing mode Thomas Huth
2018-08-16 11:35 ` [Qemu-devel] [PATCH v2 3/8] hw/timer/mc146818rtc: White space clean-up Thomas Huth
2018-08-17 10:27 ` Juan Quintela
2018-08-16 11:35 ` [Qemu-devel] [PATCH v2 4/8] hw/timer/mc146818rtc: Fix introspection problem Thomas Huth
2018-08-17 10:29 ` Juan Quintela
2018-08-16 11:35 ` [Qemu-devel] [PATCH v2 5/8] tests: Skip old versioned machine types in quick testing mode Thomas Huth
2018-08-17 10:33 ` Juan Quintela [this message]
2018-08-16 11:35 ` [Qemu-devel] [PATCH v2 6/8] tests/device-introspection: Check that the qom-tree and qtree do not change Thomas Huth
2018-08-17 10:34 ` Juan Quintela
2018-08-16 11:35 ` [Qemu-devel] [PATCH v2 7/8] tests/device-introspect: Test with all machines, not only with "none" Thomas Huth
2018-08-17 10:56 ` Juan Quintela
2018-08-16 11:35 ` [Qemu-devel] [PATCH v2 8/8] MAINTAINERS: add maintainers for qtest Thomas Huth
2018-08-17 10:57 ` Juan Quintela
2018-08-17 10:34 ` [Qemu-devel] [PATCH v2 0/8] Various qtest-related patches and a mc146818rtc fix Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2ixuvt4.fsf@trasno.org \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.