[MODERATED] Re: [PATCH v2 5/8] kvm: handle host mode irqs 5

[Nicolai Stange <nstange@suse.de>]

speck for Peter Zijlstra  <speck@linutronix.de> writes:

> On Fri, Jul 27, 2018 at 01:22:16PM +0200, speck for Nicolai Stange wrote:
>> --- a/arch/x86/include/asm/hardirq.h
>> +++ b/arch/x86/include/asm/hardirq.h
>> @@ -7,6 +7,9 @@
>>  
>>  typedef struct {
>>  	u16 __softirq_pending;
>> +#if IS_ENABLED(CONFIG_KVM_INTEL)
>> +	bool kvm_cpu_l1tf_flush_l1d;
>> +#endif
>
> NAK on using _Bool in a composite type.
>

Do I get it right that you'd prefer a bitfield?

If so, I chose a bool here because updating a bitfield would
involve a rmw operation and we might want to make NMIs set that flag
opportunistically in a later patch.

This series ignores NMIs for simplicity, because those issued after
local_irq_disable() and before VMENTER would still get missed.

Or did I miss your point completely?

Thanks,

Nicolai


-- 
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284 (AG Nürnberg)