From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT0mz-0004tf-04 for qemu-devel@nongnu.org; Wed, 13 Jun 2018 04:06:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT0mt-0001jE-BQ for qemu-devel@nongnu.org; Wed, 13 Jun 2018 04:05:56 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49772 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fT0mt-0001im-72 for qemu-devel@nongnu.org; Wed, 13 Jun 2018 04:05:51 -0400 From: Markus Armbruster References: <20180524044454.11792-1-peterx@redhat.com> <20180524044454.11792-3-peterx@redhat.com> Date: Wed, 13 Jun 2018 10:05:49 +0200 In-Reply-To: <20180524044454.11792-3-peterx@redhat.com> (Peter Xu's message of "Thu, 24 May 2018 12:44:54 +0800") Message-ID: <87r2lbkt5u.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 2/2] intel-iommu: start to use error_report_once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, "Michael S . Tsirkin" , Jason Wang , Markus Armbruster , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Peter Xu writes: > Replace existing trace_vtd_err() with error_report_once() then stderr > will capture something if any of the error happens, meanwhile we don't > suffer from any DDOS. Then remove the trace point. Since at it, > provide more information where proper (now we can pass parameters into > the report function). > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Signed-off-by: Peter Xu > --- > hw/i386/intel_iommu.c | 59 ++++++++++++++++++++++++------------------- > hw/i386/trace-events | 1 - > 2 files changed, 33 insertions(+), 27 deletions(-) Michael, would you give your Reviewed-by or Acked-by? I'd take the series through my tree then. [...]