From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Update virtual PCH in single
 function
Date: Mon, 28 May 2018 12:48:52 +0300
Message-ID: <87r2lwhzzv.fsf@intel.com>
References: <20180529045038.31397-1-colin.xu@intel.com>
 <20180529045038.31397-2-colin.xu@intel.com> <87tvqsi0im.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id EE80E6E1F1
 for <intel-gfx@lists.freedesktop.org>; Mon, 28 May 2018 09:44:56 +0000 (UTC)
In-Reply-To: <87tvqsi0im.fsf@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: colin.xu@intel.com, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAyOCBNYXkgMjAxOCwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g
d3JvdGU6Cj4gT24gVHVlLCAyOSBNYXkgMjAxOCwgY29saW4ueHVAaW50ZWwuY29tIHdyb3RlOgo+
PiBGcm9tOiBDb2xpbiBYdSA8Y29saW4ueHVAaW50ZWwuY29tPgo+Pgo+PiBUaGUgZXhpc3Rpbmcg
d2F5IHRvIHVwZGF0ZSB2aXJ0dWFsIFBDSCB3aWxsIHJldHVybiB3cm9uZyBQQ0ggdHlwZQo+PiBp
biBjYXNlIHRoZSBob3N0IGRvZXNuJ3QgaGF2ZSBQQ0g6Cj4+ICAgLSBpbnRlbF92aXJ0X2RldGVj
dF9wY2ggcmV0dXJucyBndWVzc2VkIFBDSCBpZCAwCj4+ICAgLSBpZCAwIG1hcHMgdG8gUENIX05P
UC4gPj4gc2hvdWxkIGJlIFBDSF9OT05FLgo+PiBTaW5jZSBQQ0hfTk9ORSBhbmQgUENIX05PUCBh
cmUgZGlmZmVyZW50IHR5cGVzLCBtaXhpbmcgdGhlbSB1cAo+PiB3aWxsIGJyZWFrIHZidCBpbml0
aWFsaXphdGlvbiBsb2dpYy4KPj4KPj4gSW4gYWRkaXRpb24sIHRvIGFkZCBuZXcgbm9uZS9ub3Ag
UENIIG92ZXJyaWRlIGZvciBhIHNwZWNpZmljCj4+IHBsYXRmb3JtLCBicmFuY2hpbmcgbmVlZCB0
byBiZSBhZGRlZCB0byBpbnRlbF92aXJ0X2RldGVjdF9wY2goKSwKPj4gaW50ZWxfcGNoX3R5cGUo
KSBhbmQgdGhlIGNhbGxlciBzaW5jZSBub25lL25vcCBQQ0ggaXMgbm90IGFsd2F5cwo+PiBtYXBw
aW5nIHRvIHRoZSBzYW1lIHByZWRlZmluZWQgUENIIGlkLgo+Pgo+PiBUaGlzIHBhdGNoIG1lcmdl
cyB0aGUgdmlydHVhbCBQQ0ggdXBkYXRlL3Nhbml0eSBjaGVjayBsb2dpYyBpbnRvCj4+IHNpbmds
ZSBmdW5jdGlvbiBpbnRlbF92aXJ0X3VwZGF0ZV9wY2goKSwgd2hpY2ggc3RpbGwga2VlcHMgdXNp
bmcKPj4gZXhpc3RpbmcgaW50ZWxfcGNoX3R5cGUoKSB0byBkbyB0aGUgc2FuaXR5IGNoZWNrLCB3
aGlsZSBtYWtpbmcgaXQKPj4gY2xlYW4gdG8gb3ZlcnJpZGUgdmlydHVhbCBQQ0ggaWQgZm9yIGEg
c3BlY2lmaWMgcGxhdGZvcm0gZm9yIGZ1dHVyZQo+PiBwbGF0Zm9ybSBlbmFibGVtZW50Lgo+Cj4g
UGxlYXNlIGtlZXAgdGhlIGFzc2lnbm1lbnQgb3V0IG9mIGludGVsX3ZpcnRfe2RldGVjdCx1cGRh
dGV9X3BjaCBsaWtlLiBJCj4gdGhpbmsgdGhlIHBhdGNoIGhlcmUgaXMgdW5uZWNlc3NhcmlseSBj
b21wbGljYXRlZC4KClRvIGVsYWJvcmF0ZSwgaW50ZWxfcGNoX3R5cGUoKSBzaG91bGQgKmFsd2F5
cyogYmUgYWJsZSB0byBtYXAgcGNoIGlkIHRvCnBjaCB0eXBlLiBUaGVyZSBzaG91bGQgbm90IGJl
IGNvbWJpbmF0aW9ucyB0aGF0IGFyZW4ndCBjb3ZlcmVkIGJ5CnRoYXQuIElmIHRoZSBzYW5pdHkg
Y2hlY2tzIHRoZXJlIG5lZWQgdG8gYWNjZXB0IEJyb3h0b24gYXMgd2VsbCwgcGVyaGFwcwpwYXNz
IGEgcGFyYW1ldGVyIHRvIGluZGljYXRlIHZpcnR1YWxpemF0aW9uLCBhbmQgYWNjZXB0IGNlcnRh
aW4gcGNoIGlkcwpmb3IgQnJveHRvbiBhcyB3ZWxsLgoKSWYgeW91J3JlIGZha2luZyBhIHBjaCBm
b3IgQnJveHRvbiwgSSBkb24ndCB0aGluayB0aGVyZSdzIGEgY2FzZSB3aGVyZQpwY2ggaWQgc2hv
dWxkIGJlIDAgYW5kIHBjaCB0eXBlIHNob3VsZCBiZSBzb21ldGhpbmcgZWxzZS4gRWl0aGVyIGJv
dGgKYXJlIHplcm8sIG9yIGJvdGggYXJlIG5vbi16ZXJvLgoKCkJSLApKYW5pCgoKCgoKPgo+IEJS
LAo+IEphbmkuCj4KPgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBYdSA8Y29saW4ueHVAaW50
ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgfCA1NiAr
KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAzMCBp
bnNlcnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5j
Cj4+IGluZGV4IGZiMzllNDBjMDg0Ny4uNjM3YmE4NjEwNGJlIDEwMDY0NAo+PiAtLS0gYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfZHJ2LmMKPj4gQEAgLTIwOSwxMCArMjA5LDExIEBAIHN0YXRpYyBib29sIGludGVsX2lz
X3ZpcnRfcGNoKHVuc2lnbmVkIHNob3J0IGlkLAo+PiAgCQkgc2RldmljZSA9PSBQQ0lfU1VCREVW
SUNFX0lEX1FFTVUpKTsKPj4gIH0KPj4gIAo+PiAtc3RhdGljIHVuc2lnbmVkIHNob3J0Cj4+IC1p
bnRlbF92aXJ0X2RldGVjdF9wY2goY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w
cml2KQo+PiArc3RhdGljIHZvaWQKPj4gK2ludGVsX3ZpcnRfdXBkYXRlX3BjaChzdHJ1Y3QgZHJt
X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICB7Cj4+ICAJdW5zaWduZWQgc2hvcnQgaWQgPSAw
Owo+PiArCWVudW0gaW50ZWxfcGNoIHBjaF90eXBlID0gUENIX05PTkU7Cj4+ICAKPj4gIAkvKgo+
PiAgCSAqIEluIGEgdmlydHVhbGl6ZWQgcGFzc3Rocm91Z2ggZW52aXJvbm1lbnQgd2UgY2FuIGJl
IGluIGEKPj4gQEAgLTIyMSwyNSArMjIyLDM3IEBAIGludGVsX3ZpcnRfZGV0ZWN0X3BjaChjb25z
dCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICAJICogbWFrZSBhbiBlZHVj
YXRlZCBndWVzcyBhcyB0byB3aGljaCBQQ0ggaXMgcmVhbGx5IHRoZXJlLgo+PiAgCSAqLwo+PiAg
Cj4+IC0JaWYgKElTX0dFTjUoZGV2X3ByaXYpKQo+PiArCWlmIChJU19HRU41KGRldl9wcml2KSkg
ewo+PiAgCQlpZCA9IElOVEVMX1BDSF9JQlhfREVWSUNFX0lEX1RZUEU7Cj4+IC0JZWxzZSBpZiAo
SVNfR0VONihkZXZfcHJpdikgfHwgSVNfSVZZQlJJREdFKGRldl9wcml2KSkKPj4gKwkJcGNoX3R5
cGUgPSBpbnRlbF9wY2hfdHlwZShkZXZfcHJpdiwgaWQpOwo+PiArCQlEUk1fREVCVUdfS01TKCJB
c3N1bWluZyBJYmV4IFBlYWsgUENIIGlkICUwNHhcbiIsIGlkKTsKPj4gKwl9IGVsc2UgaWYgKElT
X0dFTjYoZGV2X3ByaXYpIHx8IElTX0lWWUJSSURHRShkZXZfcHJpdikpIHsKPj4gIAkJaWQgPSBJ
TlRFTF9QQ0hfQ1BUX0RFVklDRV9JRF9UWVBFOwo+PiAtCWVsc2UgaWYgKElTX0hTV19VTFQoZGV2
X3ByaXYpIHx8IElTX0JEV19VTFQoZGV2X3ByaXYpKQo+PiAtCQlpZCA9IElOVEVMX1BDSF9MUFRf
TFBfREVWSUNFX0lEX1RZUEU7Cj4+IC0JZWxzZSBpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikgfHwg
SVNfQlJPQURXRUxMKGRldl9wcml2KSkKPj4gLQkJaWQgPSBJTlRFTF9QQ0hfTFBUX0RFVklDRV9J
RF9UWVBFOwo+PiAtCWVsc2UgaWYgKElTX1NLWUxBS0UoZGV2X3ByaXYpIHx8IElTX0tBQllMQUtF
KGRldl9wcml2KSkKPj4gKwkJcGNoX3R5cGUgPSBpbnRlbF9wY2hfdHlwZShkZXZfcHJpdiwgaWQp
Owo+PiArCQlEUk1fREVCVUdfS01TKCJBc3N1bWluZyBDb3VnYXJQb2ludCBQQ0ggaWQgJTA0eFxu
IiwgaWQpOwo+PiArCX0gZWxzZSBpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikgfHwgSVNfQlJPQURX
RUxMKGRldl9wcml2KSkgewo+PiArCQlpZiAoSVNfSFNXX1VMVChkZXZfcHJpdikgfHwgSVNfQkRX
X1VMVChkZXZfcHJpdikpCj4+ICsJCQlpZCA9IElOVEVMX1BDSF9MUFRfTFBfREVWSUNFX0lEX1RZ
UEU7Cj4+ICsJCWVsc2UKPj4gKwkJCWlkID0gSU5URUxfUENIX0xQVF9ERVZJQ0VfSURfVFlQRTsK
Pj4gKwkJcGNoX3R5cGUgPSBpbnRlbF9wY2hfdHlwZShkZXZfcHJpdiwgaWQpOwo+PiArCQlEUk1f
REVCVUdfS01TKCJBc3N1bWluZyBMeW54UG9pbnQgUENIIGlkICUwNHhcbiIsIGlkKTsKPj4gKwl9
IGVsc2UgaWYgKElTX1NLWUxBS0UoZGV2X3ByaXYpIHx8IElTX0tBQllMQUtFKGRldl9wcml2KSkg
ewo+PiAgCQlpZCA9IElOVEVMX1BDSF9TUFRfREVWSUNFX0lEX1RZUEU7Cj4+IC0JZWxzZSBpZiAo
SVNfQ09GRkVFTEFLRShkZXZfcHJpdikgfHwgSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpCj4+ICsJ
CXBjaF90eXBlID0gaW50ZWxfcGNoX3R5cGUoZGV2X3ByaXYsIGlkKTsKPj4gKwkJRFJNX0RFQlVH
X0tNUygiQXNzdW1pbmcgU3VucmlzZVBvaW50IFBDSCBpZCAlMDR4XG4iLCBpZCk7Cj4+ICsJfSBl
bHNlIGlmIChJU19DT0ZGRUVMQUtFKGRldl9wcml2KSB8fCBJU19DQU5OT05MQUtFKGRldl9wcml2
KSkgewo+PiAgCQlpZCA9IElOVEVMX1BDSF9DTlBfREVWSUNFX0lEX1RZUEU7Cj4+ICsJCXBjaF90
eXBlID0gaW50ZWxfcGNoX3R5cGUoZGV2X3ByaXYsIGlkKTsKPj4gKwkJRFJNX0RFQlVHX0tNUygi
QXNzdW1pbmcgQ2Fubm9uUG9pbnQgUENIIGlkICUwNHhcbiIsIGlkKTsKPj4gKwl9IGVsc2Ugewo+
PiArCQlpZCA9IDA7Cj4+ICsJCXBjaF90eXBlID0gUENIX05PUDsKPj4gKwkJRFJNX0RFQlVHX0tN
UygiQXNzdW1pbmcgTk9QIFBDSFxuIik7Cj4+ICsJfQo+PiAgCj4+IC0JaWYgKGlkKQo+PiAtCQlE
Uk1fREVCVUdfS01TKCJBc3N1bWluZyBQQ0ggSUQgJTA0eFxuIiwgaWQpOwo+PiAtCWVsc2UKPj4g
LQkJRFJNX0RFQlVHX0tNUygiQXNzdW1pbmcgbm8gUENIXG4iKTsKPj4gLQo+PiAtCXJldHVybiBp
ZDsKPj4gKwlkZXZfcHJpdi0+cGNoX3R5cGUgPSBwY2hfdHlwZTsKPj4gKwlkZXZfcHJpdi0+cGNo
X2lkID0gaWQ7Cj4+ICB9Cj4+ICAKPj4gIHN0YXRpYyB2b2lkIGludGVsX2RldGVjdF9wY2goc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiBAQCAtMjgxLDE2ICsyOTQsNyBAQCBz
dGF0aWMgdm9pZCBpbnRlbF9kZXRlY3RfcGNoKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf
cHJpdikKPj4gIAkJCWJyZWFrOwo+PiAgCQl9IGVsc2UgaWYgKGludGVsX2lzX3ZpcnRfcGNoKGlk
LCBwY2gtPnN1YnN5c3RlbV92ZW5kb3IsCj4+ICAJCQkJCSBwY2gtPnN1YnN5c3RlbV9kZXZpY2Up
KSB7Cj4+IC0JCQlpZCA9IGludGVsX3ZpcnRfZGV0ZWN0X3BjaChkZXZfcHJpdik7Cj4+IC0JCQlp
ZiAoaWQpIHsKPj4gLQkJCQlwY2hfdHlwZSA9IGludGVsX3BjaF90eXBlKGRldl9wcml2LCBpZCk7
Cj4+IC0JCQkJaWYgKFdBUk5fT04ocGNoX3R5cGUgPT0gUENIX05PTkUpKQo+PiAtCQkJCQlwY2hf
dHlwZSA9IFBDSF9OT1A7Cj4+IC0JCQl9IGVsc2Ugewo+PiAtCQkJCXBjaF90eXBlID0gUENIX05P
UDsKPj4gLQkJCX0KPj4gLQkJCWRldl9wcml2LT5wY2hfdHlwZSA9IHBjaF90eXBlOwo+PiAtCQkJ
ZGV2X3ByaXYtPnBjaF9pZCA9IGlkOwo+PiArCQkJaW50ZWxfdmlydF91cGRhdGVfcGNoKGRldl9w
cml2KTsKPj4gIAkJCWJyZWFrOwo+PiAgCQl9Cj4+ICAJfQoKLS0gCkphbmkgTmlrdWxhLCBJbnRl
bCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz
dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vaW50ZWwtZ2Z4Cg==