From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: Eric Biggers <ebiggers3@gmail.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
linux-wireless@vger.kernel.org,
Haim Dreyfuss <haim.dreyfuss@intel.com>
Subject: Re: [4.17 iwlwifi regression] NULL pointer dereference in reg_query_regdb_wmm()
Date: Mon, 21 May 2018 19:25:38 +0300 [thread overview]
Message-ID: <87r2m5f01p.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1469fa7134c62e0323ea1b409d98953f6c1a70a3.camel@coelho.fi> (Luca Coelho's message of "Mon, 21 May 2018 10:42:00 +0300")
Luca Coelho <luca@coelho.fi> writes:
> On Sat, 2018-05-19 at 11:33 -0700, Eric Biggers wrote:
>> Hello,
>>
>> Using v4.17-rc5, on a laptop with an "Intel Corporation Wireless 3165
>> (rev 79)"
>> using the iwlwifi driver, I get a NULL pointer dereference
>> immediately after
>> boot. Apparently, the 'regdb' variable in net/wireless/reg.c is
>> NULL, yet
>> reg_query_regdb_wmm() is checking for IS_ERR(). It goes away if I
>> revert commit
>> 77e30e10ee28a5 ("iwlwifi: mvm: query regdb for wmm rule if
>> needed"). The
>> symbolized crash report is:
>>
>> BUG: unable to handle kernel NULL pointer dereference at
>> 000000000000000a
>
> Thanks for the report and analysis! Haim is working on a fix and I will
> send it out later today.
We are on -rc6 already and getting close to the final v4.17 release. I
wonder should we just revert 77e30e10ee28a5 for now?
--
Kalle Valo
next prev parent reply other threads:[~2018-05-21 16:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 18:33 [4.17 iwlwifi regression] NULL pointer dereference in reg_query_regdb_wmm() Eric Biggers
2018-05-21 7:42 ` Luca Coelho
2018-05-21 16:25 ` Kalle Valo [this message]
2018-05-21 16:30 ` Luca Coelho
2018-05-21 17:57 ` Kalle Valo
2018-05-21 10:10 ` Dreyfuss, Haim
2018-05-21 16:28 ` Kalle Valo
2018-05-21 16:56 ` Dreyfuss, Haim
2018-05-22 14:06 ` Kalle Valo
2018-05-22 4:47 ` Eric Biggers
2018-05-22 4:59 ` Eric Biggers
2018-05-22 7:58 ` Dreyfuss, Haim
2018-05-21 10:11 ` Dreyfuss, Haim
2018-05-21 20:34 ` [PATCH] cfg80211: fix NULL pointer derference when querying regdb Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2m5f01p.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ebiggers3@gmail.com \
--cc=haim.dreyfuss@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.