From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/scripts/fix-rpath: exclude /lib/firmware in the target
Date: Tue, 01 May 2018 08:51:23 +0200 [thread overview]
Message-ID: <87r2mvoolw.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180412115009.8432-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Thu, 12 Apr 2018 13:50:09 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> The /lib/firmware directory contains random firmware for various
> devices. It happens that some of them might be or appear to be ELF
> files, but they shouldn't be checked by fix-rpath. For example, one of
> the Qualcomm VPU firmware file appears to be an ELF file, but patchelf
> isn't happy about it:
> $ ./output/host/bin/patchelf --print-rpath output/target/lib/firmware/qcom/venus-4.2/venus.b00
> patchelf: patchelf.cc:387: void ElfFile<Elf_Ehdr, Elf_Phdr, Elf_Shdr, Elf_Addr, Elf_Off, Elf_Dyn, Elf_Sym>::parse() [with Elf_Ehdr = Elf32_Ehdr; Elf_Phdr = Elf32_Phdr; Elf_Shdr = Elf32_Shdr; Elf_Addr = unsigned int; Elf_Off = unsigned int; Elf_Dyn = Elf32_Dyn; Elf_Sym = Elf32_Sym]: Assertion `shstrtabIndex < shdrs.size()' failed.
> Aborted (core dumped)
> Even though patchelf definitely shouldn't crash, it anyway doesn't
> make sense to check ELF files in /lib/firmware, so let's exclude this
> directory from our check.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2018.02.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-05-01 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 11:50 [Buildroot] [PATCH] support/scripts/fix-rpath: exclude /lib/firmware in the target Thomas Petazzoni
2018-04-12 17:04 ` Yann E. MORIN
2018-04-12 19:16 ` Thomas Petazzoni
2018-05-01 6:51 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2mvoolw.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.