All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>,
	"Takashi Iwai" <tiwai-l3A5Bk7waGM@public.gmane.org>,
	"Christian K6nig" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
Cc: David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
	dri-devel
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	amd-gfx mailing list
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH 2/2] drm/amdgpu: Add modeset module option
Date: Tue, 03 Apr 2018 12:53:30 +0300	[thread overview]
Message-ID: <87r2nwaa5h.fsf@intel.com> (raw)
In-Reply-To: <e4933491-65be-4b31-95de-cf1147dd312c-otUistvHUpPR7s880joybQ@public.gmane.org>

On Tue, 03 Apr 2018, Michel Dänzer <michel@daenzer.net> wrote:
> On 2018-04-03 11:02 AM, Takashi Iwai wrote:
>> Agreed with the naming mess.  But OTOH, it's already a thing that is
>> too popular to kill.  You can add a more suitable option name, but you
>> cannot drop these existing ones easily.  It's already in a gray zone
>> of the golden "don't break user-space" rule.
>
> That's quite a stretch argument, given that amdgpu has never supported
> the modeset parameter.

That much is clear.

> Also, module parameters aren't UAPI.

[citation needed]. I agree with Takashi it's a gray area.

You can have "unsafe" module parameters that taint the kernel when set,
see module_param_unsafe and module_param_named_unsafe. Using those
should make it clear all bets are off.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-04-03  9:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30 20:45 [PATCH 1/2] drm/amdgpu: Fix memory leaks at amdgpu_init() error path Takashi Iwai
     [not found] ` <20180330204512.16863-1-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-03-30 20:45   ` [PATCH 2/2] drm/amdgpu: Add modeset module option Takashi Iwai
     [not found]     ` <20180330204512.16863-2-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-04-01 17:39       ` Christian König
     [not found]         ` <c95f9e61-c921-42de-9e03-851d785ab5fc-5C7GfCeVMHo@public.gmane.org>
2018-04-01 17:45           ` Ilia Mirkin
2018-04-01 17:58             ` Christian König
     [not found]               ` <706f4d0d-4583-2c8a-447d-f6cdd3429ad5-5C7GfCeVMHo@public.gmane.org>
2018-04-01 18:21                 ` Takashi Iwai
     [not found]                   ` <s5ho9j24wk9.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-04-01 20:12                     ` Christian König
     [not found]                       ` <0ecce204-6af8-2395-ac40-391e3b655bed-5C7GfCeVMHo@public.gmane.org>
2018-04-03  9:29                         ` Daniel Vetter
     [not found]                           ` <20180403092948.GQ3881-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-04-03 11:30                             ` Christian König
2018-04-03 13:26                           ` Ilia Mirkin
     [not found]                             ` <CAKb7UvhG5nO9q1M=6fu6mnChObsskxFzgGXQPUJQCk1Q+E9ffQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-04-03 13:32                               ` Michel Dänzer
     [not found]                                 ` <ea3e89e9-0a31-604f-c3f4-2693a0f9ca92-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-04-03 13:39                                   ` Ilia Mirkin
     [not found]                                     ` <CAKb7UvibPPu9O0HKbGBz7Zd9av-1YR905zH5VypiYeMRbGasGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-04-03 13:47                                       ` Michel Dänzer
     [not found]                                         ` <957f79ce-80e9-d240-3632-e8b346708646-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-04-03 14:06                                           ` Ville Syrjälä
     [not found]                                             ` <20180403140603.GA5453-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-03 15:02                                               ` Daniel Vetter
     [not found]                                                 ` <20180403150235.GV3881-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-04-03 16:54                                                   ` Ville Syrjälä
2018-04-03 15:09                                             ` Michel Dänzer
     [not found]             ` <CAKb7Uvh_CxE=Zg_F0tentwXK64_baxs0TCQ-K9Mh_Mjf+NV_DA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-04-03  8:36               ` Michel Dänzer
2018-04-03  8:57                 ` Christian König
     [not found]                   ` <781c3a0b-e199-c637-410a-521fe5fd5170-5C7GfCeVMHo@public.gmane.org>
2018-04-03  9:02                     ` Takashi Iwai
     [not found]                       ` <s5hpo3g1x4m.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-04-03  9:18                         ` Michel Dänzer
2018-04-03  9:44                           ` Takashi Iwai
     [not found]                             ` <s5h1sfwk4ja.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-04-03 13:01                               ` Michel Dänzer
     [not found]                           ` <e4933491-65be-4b31-95de-cf1147dd312c-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-04-03  9:53                             ` Jani Nikula [this message]
2019-09-25  8:07       ` Dave Airlie
2019-09-25  9:04         ` Koenig, Christian
2018-04-02 17:36   ` [PATCH 1/2] drm/amdgpu: Fix memory leaks at amdgpu_init() error path Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2nwaa5h.fsf@intel.com \
    --to=jani.nikula-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=michel-otUistvHUpPR7s880joybQ@public.gmane.org \
    --cc=tiwai-l3A5Bk7waGM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.