From: Kalle Valo <kvalo@codeaurora.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Tycho Andersen <tycho@tycho.ws>,
Kees Cook <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH] rsi: Remove stack VLA usage
Date: Fri, 09 Mar 2018 12:37:06 +0200 [thread overview]
Message-ID: <87r2ota625.fsf@codeaurora.org> (raw)
In-Reply-To: <1520577493-24603-1-git-send-email-me@tobin.cc> (Tobin C. Harding's message of "Fri, 9 Mar 2018 17:38:13 +1100")
"Tobin C. Harding" <me@tobin.cc> writes:
> The kernel would like to have all stack VLA usage removed[1]. rsi uses
> a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size
> is defined using a magic number. We can use a pre-processor defined
> constant and declare the array to maximum size. We add a check before
> accessing the array in case of programmer error.
>
> [1]: https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
Please CC linux-wireless list, otherwise patchwork won't see the patch
and I can't apply it.
--
Kalle Valo
next prev parent reply other threads:[~2018-03-09 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 6:38 [PATCH] rsi: Remove stack VLA usage Tobin C. Harding
2018-03-09 10:37 ` Kalle Valo [this message]
2018-03-11 21:00 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2ota625.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=netdev@vger.kernel.org \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.