From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXA42-0007Ti-Nc for qemu-devel@nongnu.org; Thu, 04 Jan 2018 13:16:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXA3z-0000YB-EO for qemu-devel@nongnu.org; Thu, 04 Jan 2018 13:16:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35008) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXA3z-0000WS-1C for qemu-devel@nongnu.org; Thu, 04 Jan 2018 13:16:23 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD7895D676 for ; Thu, 4 Jan 2018 18:16:21 +0000 (UTC) From: Juan Quintela In-Reply-To: <3e95592d-4846-bb91-961d-03ca10e3ae18@redhat.com> (Eric Blake's message of "Fri, 1 Dec 2017 12:28:20 -0600") References: <20171201125750.1372-1-quintela@redhat.com> <20171201125750.1372-2-quintela@redhat.com> <3e95592d-4846-bb91-961d-03ca10e3ae18@redhat.com> Reply-To: quintela@redhat.com Date: Thu, 04 Jan 2018 19:16:17 +0100 Message-ID: <87r2r5a3ri.fsf@secure.laptop> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 1/2] migration: Create tcp_port parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com Eric Blake wrote: > On 12/01/2017 06:57 AM, Juan Quintela wrote: >> It will be used to store the uri tcp_port parameter. This is the only >> parameter than can change and we can need to be able to connect to it. >> >> Signed-off-by: Juan Quintela >> >> -- >> > >> @@ -2422,6 +2430,8 @@ static Property migration_properties[] = { >> DEFINE_PROP_SIZE("xbzrle-cache-size", MigrationState, >> parameters.xbzrle_cache_size, >> DEFAULT_MIGRATE_XBZRLE_CACHE_SIZE), >> + DEFINE_PROP_UINT16("x-tcp-port", MigrationState, >> + parameters.tcp_port, 0), > > Why is this one experimental when others are not, changing. Actually, because I don't know if everybody wants this. > >> /* Migration capabilities */ >> DEFINE_PROP_MIG_CAP("x-xbzrle", MIGRATION_CAPABILITY_XBZRLE), >> diff --git a/qapi/migration.json b/qapi/migration.json >> index 4cd3d13158..e2a1d86216 100644 >> --- a/qapi/migration.json >> +++ b/qapi/migration.json >> @@ -488,6 +488,9 @@ >> # and a power of 2 >> # (Since 2.11) >> # >> +# @tcp-port: Only used for tcp, to know what is the real port > > s/what is the real port/what the real port is/ Changed. >> +# (Since 2.12) >> +# > > Especially since it is not experimental here? > >> @@ -564,6 +567,10 @@ >> # needs to be a multiple of the target page size >> # and a power of 2 >> # (Since 2.11) >> +# >> +# @tcp-port: Only used for tcp, to know what is the real port > > same wording tweak Changed.. >> +# (Since 2.12) >> +# >> # Since: 2.4 >> ## >> # TODO either fuse back into MigrationParameters, or make >> @@ -582,7 +589,8 @@ >> '*block-incremental': 'bool', >> '*x-multifd-channels': 'int', >> '*x-multifd-page-count': 'int', >> - '*xbzrle-cache-size': 'size' } } >> + '*xbzrle-cache-size': 'size' , > > the space before comma looks unusual (although it's harmless) Changed. Thanks. >> + '*tcp-port': 'uint16'} }