All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/vbt: Fix HDMI level shifter and max data rate bitfield sizes
Date: Fri, 27 Oct 2017 23:38:55 +0300	[thread overview]
Message-ID: <87r2toe36o.fsf@intel.com> (raw)
In-Reply-To: <20171027201738.3640-1-ville.syrjala@linux.intel.com>

On Fri, 27 Oct 2017, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The HDMI level shifter value should be 5 bits and the max data rate 3 bits.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Reported-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h
> index f225c288a121..3c3c421e2e43 100644
> --- a/drivers/gpu/drm/i915/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
> @@ -342,8 +342,8 @@ struct child_device_config {
>  			u8 i2c_speed;
>  			u8 dp_onboard_redriver;			/* 158 */
>  			u8 dp_ondock_redriver;			/* 158 */
> -			u8 hdmi_level_shifter_value:4;		/* 169 */
> -			u8 hdmi_max_data_rate:4;		/* 204 */
> +			u8 hdmi_level_shifter_value:5;		/* 169 */
> +			u8 hdmi_max_data_rate:3;		/* 204 */
>  			u16 dtd_buf_ptr;			/* 161 */
>  			u8 edidless_efp:1;			/* 161 */
>  			u8 compression_enable:1;		/* 198 */

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-10-27 20:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 20:17 [PATCH] drm/i915/vbt: Fix HDMI level shifter and max data rate bitfield sizes Ville Syrjala
2017-10-27 20:38 ` Jani Nikula [this message]
2017-10-27 21:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-27 22:57 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-10-30 15:21 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2toe36o.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.