From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6476152782824931328 X-Received: by 10.107.180.72 with SMTP id d69mr392966iof.50.1507881535361; Fri, 13 Oct 2017 00:58:55 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.107.170.138 with SMTP id g10ls679264ioj.19.gmail; Fri, 13 Oct 2017 00:58:54 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBdfLsCvehEXxh6tm3pTSNSRijE8A297Wj+eYfOm20pTaD2vxPLngwz4hduCEFIFLZhQDQZ X-Received: by 10.36.179.3 with SMTP id e3mr644816itf.6.1507881534600; Fri, 13 Oct 2017 00:58:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507881534; cv=none; d=google.com; s=arc-20160816; b=tqTtEGOT0Vh7RtshAQ94jT8+0fb++1oqgj032lrbcRc8tA3IqOy6kEfKokq3yDKdq7 XNExZAQrXLkCwLcoACHNFTeZDG3QC+P8+C9cvgeiJwCF2jV0pEkPocN03bZ+qoB69lIW 1ewFYMHrWFU2hpHCbvY4XBVK9pDPmHs3l3O8GAMNj28BikiT1kNlvtc8nBj88yQdP2/x ABDuz5vS6BokeDVXbzhRrIEWqKiXab/zc3nxhLyYls3oU0meAHbKTZTe+C2KpJclMZC9 UMiLUSUJzxudqQsNZ0sVTS4GNI4uMGTAdzzqIszMBxwN/n4iq7UmPsn6Z2wI7zF+znsk g99A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:message-id:date:references:organization:in-reply-to :subject:cc:to:from:arc-authentication-results; bh=2+D0wPtkg6oQ0OaIn3tz16C5gxONUm3W58J0gQDac4w=; b=DqYi5FhHGWQnjZjLDFgFK/g6mczwuHHvpzoerj9lry4bQxpbBWznyo5HgNzzcJrhB/ Q2byhW4Nssj6Dg45XCnWTanl0Pq94PTkJzAOEWTvhygJN0k9Z+jiCnhEAwCLEC5L735s EkcVCcMRWFAPzsakE9EGwtuwV7t/CFiAT6Ti1AU5n5JxAqxOz2kSAqBvUI3ar7lxzvJC ih0tta+HB5GU2mmEONq5KGJXkBg0VANcCSsDsvWQ0fQxWBsM7WeWSbBLqWT4QaPDCHXc dODxgQ486YmzaudDlCGixt8mlGE20Y87KH9XBrQ7HDyc1s4HM5IP07MHc+DGkZMCGfOO MMHQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jani.nikula@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=jani.nikula@intel.com Return-Path: Received: from mga11.intel.com (mga11.intel.com. [192.55.52.93]) by gmr-mx.google.com with ESMTPS id r66si60978itc.0.2017.10.13.00.58.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Oct 2017 00:58:54 -0700 (PDT) Received-SPF: pass (google.com: domain of jani.nikula@intel.com designates 192.55.52.93 as permitted sender) client-ip=192.55.52.93; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jani.nikula@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=jani.nikula@intel.com Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Oct 2017 00:58:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,369,1503385200"; d="scan'208";a="909553965" Received: from abousale-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.38.121]) by FMSMGA003.fm.intel.com with ESMTP; 13 Oct 2017 00:58:50 -0700 From: Jani Nikula To: Harsha Sharma , daniel.vetter@ffwll.ch, seanpaul@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, Harsha Sharma Subject: Re: [PATCH v2] drm: Replace kzalloc with kcalloc In-Reply-To: <20171013073747.29877-1-harshasharmaiitr@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20171013073747.29877-1-harshasharmaiitr@gmail.com> Date: Fri, 13 Oct 2017 10:58:33 +0300 Message-ID: <87r2u7lbrq.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain On Fri, 13 Oct 2017, Harsha Sharma wrote: > Prefer kcalloc over kzalloc to allocate an array. > This patch fixes checkcpatch issue. > > Signed-off-by: Harsha Sharma Reviewed-by: Jani Nikula > --- > Changes in v2: > -kcalloc will take 3 arguments > > drivers/gpu/drm/drm_crtc_helper.c | 4 ++-- > drivers/gpu/drm/drm_fb_helper.c | 2 +- > drivers/gpu/drm/drm_plane_helper.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c > index eab36a460638..5a84c3bc915d 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -562,12 +562,12 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set, > * Allocate space for the backup of all (non-pointer) encoder and > * connector data. > */ > - save_encoder_crtcs = kzalloc(dev->mode_config.num_encoder * > + save_encoder_crtcs = kcalloc(dev->mode_config.num_encoder, > sizeof(struct drm_crtc *), GFP_KERNEL); > if (!save_encoder_crtcs) > return -ENOMEM; > > - save_connector_encoders = kzalloc(dev->mode_config.num_connector * > + save_connector_encoders = kcalloc(dev->mode_config.num_connector, > sizeof(struct drm_encoder *), GFP_KERNEL); > if (!save_connector_encoders) { > kfree(save_encoder_crtcs); > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 1b8f013ffa65..de31e52ab9cb 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -2266,7 +2266,7 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper, > if (modes[n] == NULL) > return best_score; > > - crtcs = kzalloc(fb_helper->connector_count * > + crtcs = kcalloc(fb_helper->connector_count, > sizeof(struct drm_fb_helper_crtc *), GFP_KERNEL); > if (!crtcs) > return best_score; > diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c > index 06aee1741e96..759ed93f4ba8 100644 > --- a/drivers/gpu/drm/drm_plane_helper.c > +++ b/drivers/gpu/drm/drm_plane_helper.c > @@ -354,7 +354,7 @@ int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc, > /* Find current connectors for CRTC */ > num_connectors = get_connectors_for_crtc(crtc, NULL, 0); > BUG_ON(num_connectors == 0); > - connector_list = kzalloc(num_connectors * sizeof(*connector_list), > + connector_list = kcalloc(num_connectors, sizeof(*connector_list), > GFP_KERNEL); > if (!connector_list) > return -ENOMEM; -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2] drm: Replace kzalloc with kcalloc Date: Fri, 13 Oct 2017 10:58:33 +0300 Message-ID: <87r2u7lbrq.fsf@intel.com> References: <20171013073747.29877-1-harshasharmaiitr@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E6876EA4D for ; Fri, 13 Oct 2017 07:58:54 +0000 (UTC) In-Reply-To: <20171013073747.29877-1-harshasharmaiitr@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: daniel.vetter@ffwll.ch, seanpaul@chromium.org Cc: outreachy-kernel@googlegroups.com, Harsha Sharma , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAxMyBPY3QgMjAxNywgSGFyc2hhIFNoYXJtYSA8aGFyc2hhc2hhcm1haWl0ckBnbWFp bC5jb20+IHdyb3RlOgo+IFByZWZlciBrY2FsbG9jIG92ZXIga3phbGxvYyB0byBhbGxvY2F0ZSBh biBhcnJheS4KPiBUaGlzIHBhdGNoIGZpeGVzIGNoZWNrY3BhdGNoIGlzc3VlLgo+Cj4gU2lnbmVk LW9mZi1ieTogSGFyc2hhIFNoYXJtYSA8aGFyc2hhc2hhcm1haWl0ckBnbWFpbC5jb20+CgpSZXZp ZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCgo+IC0tLQo+IENo YW5nZXMgaW4gdjI6Cj4gIC1rY2FsbG9jIHdpbGwgdGFrZSAzIGFyZ3VtZW50cwo+Cj4gIGRyaXZl cnMvZ3B1L2RybS9kcm1fY3J0Y19oZWxwZXIuYyAgfCA0ICsrLS0KPiAgZHJpdmVycy9ncHUvZHJt L2RybV9mYl9oZWxwZXIuYyAgICB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZV9o ZWxwZXIuYyB8IDIgKy0KPiAgMyBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVs ZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2hlbHBl ci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2hlbHBlci5jCj4gaW5kZXggZWFiMzZhNDYw NjM4Li41YTg0YzNiYzkxNWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRj X2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2hlbHBlci5jCj4gQEAg LTU2MiwxMiArNTYyLDEyIEBAIGludCBkcm1fY3J0Y19oZWxwZXJfc2V0X2NvbmZpZyhzdHJ1Y3Qg ZHJtX21vZGVfc2V0ICpzZXQsCj4gIAkgKiBBbGxvY2F0ZSBzcGFjZSBmb3IgdGhlIGJhY2t1cCBv ZiBhbGwgKG5vbi1wb2ludGVyKSBlbmNvZGVyIGFuZAo+ICAJICogY29ubmVjdG9yIGRhdGEuCj4g IAkgKi8KPiAtCXNhdmVfZW5jb2Rlcl9jcnRjcyA9IGt6YWxsb2MoZGV2LT5tb2RlX2NvbmZpZy5u dW1fZW5jb2RlciAqCj4gKwlzYXZlX2VuY29kZXJfY3J0Y3MgPSBrY2FsbG9jKGRldi0+bW9kZV9j b25maWcubnVtX2VuY29kZXIsCj4gIAkJCQlzaXplb2Yoc3RydWN0IGRybV9jcnRjICopLCBHRlBf S0VSTkVMKTsKPiAgCWlmICghc2F2ZV9lbmNvZGVyX2NydGNzKQo+ICAJCXJldHVybiAtRU5PTUVN Owo+ICAKPiAtCXNhdmVfY29ubmVjdG9yX2VuY29kZXJzID0ga3phbGxvYyhkZXYtPm1vZGVfY29u ZmlnLm51bV9jb25uZWN0b3IgKgo+ICsJc2F2ZV9jb25uZWN0b3JfZW5jb2RlcnMgPSBrY2FsbG9j KGRldi0+bW9kZV9jb25maWcubnVtX2Nvbm5lY3RvciwKPiAgCQkJCXNpemVvZihzdHJ1Y3QgZHJt X2VuY29kZXIgKiksIEdGUF9LRVJORUwpOwo+ICAJaWYgKCFzYXZlX2Nvbm5lY3Rvcl9lbmNvZGVy cykgewo+ICAJCWtmcmVlKHNhdmVfZW5jb2Rlcl9jcnRjcyk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBl ci5jCj4gaW5kZXggMWI4ZjAxM2ZmYTY1Li5kZTMxZTUyYWI5Y2IgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f ZmJfaGVscGVyLmMKPiBAQCAtMjI2Niw3ICsyMjY2LDcgQEAgc3RhdGljIGludCBkcm1fcGlja19j cnRjcyhzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyLAo+ICAJaWYgKG1vZGVzW25dID09 IE5VTEwpCj4gIAkJcmV0dXJuIGJlc3Rfc2NvcmU7Cj4gIAo+IC0JY3J0Y3MgPSBremFsbG9jKGZi X2hlbHBlci0+Y29ubmVjdG9yX2NvdW50ICoKPiArCWNydGNzID0ga2NhbGxvYyhmYl9oZWxwZXIt PmNvbm5lY3Rvcl9jb3VudCwKPiAgCQkJc2l6ZW9mKHN0cnVjdCBkcm1fZmJfaGVscGVyX2NydGMg KiksIEdGUF9LRVJORUwpOwo+ICAJaWYgKCFjcnRjcykKPiAgCQlyZXR1cm4gYmVzdF9zY29yZTsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZV9oZWxwZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fcGxhbmVfaGVscGVyLmMKPiBpbmRleCAwNmFlZTE3NDFlOTYuLjc1OWVk OTNmNGJhOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lX2hlbHBlci5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZV9oZWxwZXIuYwo+IEBAIC0zNTQsNyAr MzU0LDcgQEAgaW50IGRybV9wcmltYXJ5X2hlbHBlcl91cGRhdGUoc3RydWN0IGRybV9wbGFuZSAq cGxhbmUsIHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCS8qIEZpbmQgY3VycmVudCBjb25uZWN0 b3JzIGZvciBDUlRDICovCj4gIAludW1fY29ubmVjdG9ycyA9IGdldF9jb25uZWN0b3JzX2Zvcl9j cnRjKGNydGMsIE5VTEwsIDApOwo+ICAJQlVHX09OKG51bV9jb25uZWN0b3JzID09IDApOwo+IC0J Y29ubmVjdG9yX2xpc3QgPSBremFsbG9jKG51bV9jb25uZWN0b3JzICogc2l6ZW9mKCpjb25uZWN0 b3JfbGlzdCksCj4gKwljb25uZWN0b3JfbGlzdCA9IGtjYWxsb2MobnVtX2Nvbm5lY3RvcnMsIHNp emVvZigqY29ubmVjdG9yX2xpc3QpLAo+ICAJCQkJIEdGUF9LRVJORUwpOwo+ICAJaWYgKCFjb25u ZWN0b3JfbGlzdCkKPiAgCQlyZXR1cm4gLUVOT01FTTsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwg T3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==