From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Cyril Bur <cyrilbur@gmail.com>,
dwmw2@infradead.org, computersforpeace@gmail.com,
mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: powernv_flash: Lock around concurrent access to OPAL
Date: Tue, 18 Jul 2017 15:01:03 +1000 [thread overview]
Message-ID: <87r2xecp9s.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170607054355.10590-2-cyrilbur@gmail.com>
Cyril Bur <cyrilbur@gmail.com> writes:
> OPAL can only manage one flash access at a time and will return an
> OPAL_BUSY error for each concurrent access to the flash. The simplest
> way to prevent this from happening is with a mutex.
>
> Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
> ---
> This is to address https://github.com/open-power/skiboot/issues/80
part of me wants to say "let's only take the lock if we ever get back
OPAL_BUSY" or something like that (have a DT property to say the flash
supports concurrent ops?)
Although the other part of me says "you're overthinking this, get back
to the work you're meant to be doing" :)
--
Stewart Smith
OPAL Architect, IBM.
prev parent reply other threads:[~2017-07-18 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 5:43 [PATCH 1/2] mtd: powernv_flash: Use WARN_ON_ONCE() rather than BUG_ON() Cyril Bur
2017-06-07 5:43 ` [PATCH 2/2] mtd: powernv_flash: Lock around concurrent access to OPAL Cyril Bur
2017-07-18 5:01 ` Stewart Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2xecp9s.fsf@linux.vnet.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=computersforpeace@gmail.com \
--cc=cyrilbur@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.