Re: [PATCH 03/15] drm/i915: introduce page_size_mask to dev_info

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 01 Jun 2017, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> On ke, 2017-05-31 at 19:51 +0100, Matthew Auld wrote:
>> In preparation for huge gtt pages expose a page_size_mask as part of the
>> device info, to indicate the page sizes supported by the HW.  Currently
>> only 4K is supported.
>> 
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>
> <SNIP>
>
> I don't quite get why there can't be more inheritance when declaring
> these (Jani CC'd), but not related to this patch.

Yeah, could use more inheritance, but can also be follow-up. *shrug*

BR,
Jani.



>  
>>  /* Keep in gen based order, and chronological order within a gen */
>> +
>> +#define GEN_DEFAULT_PAGE_SIZES \
>> +	.page_size_mask = I915_GTT_PAGE_SIZE_4K
>> +
>>  #define GEN2_FEATURES \
>>  	.gen = 2, .num_pipes = 1, \
>>  	.has_overlay = 1, .overlay_needs_physical = 1, \
>> @@ -64,6 +68,7 @@
>>  	.unfenced_needs_alignment = 1, \
>>  	.ring_mask = RENDER_RING, \
>>  	GEN_DEFAULT_PIPEOFFSETS, \
>> +	GEN_DEFAULT_PAGE_SIZES, \
>>  	CURSOR_OFFSETS
>>  
>>  static const struct intel_device_info intel_i830_info = {
>> @@ -96,6 +101,7 @@ static const struct intel_device_info intel_i865g_info = {
>>  	.has_gmch_display = 1, \
>>  	.ring_mask = RENDER_RING, \
>>  	GEN_DEFAULT_PIPEOFFSETS, \
>> +	GEN_DEFAULT_PAGE_SIZES, \
>>  	CURSOR_OFFSETS
>>  
>>  static const struct intel_device_info intel_i915g_info = {
>> @@ -158,6 +164,7 @@ static const struct intel_device_info intel_pineview_info = {
>>  	.has_gmch_display = 1, \
>>  	.ring_mask = RENDER_RING, \
>>  	GEN_DEFAULT_PIPEOFFSETS, \
>> +	GEN_DEFAULT_PAGE_SIZES, \
>>  	CURSOR_OFFSETS
>
> And goes on... Seems repetitive.
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Regards, Joonas

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx