diff for duplicates of <87r2z3lu3j.fsf@kamboji.qca.qualcomm.com> diff --git a/a/1.txt b/N1/1.txt index 88b80fc..ced09e7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ Arend van Spriel <arend.vanspriel@broadcom.com> writes: > On 31-05-17 14:16, Kalle Valo wrote: >> Adrian Chadd <adrian@freebsd.org> writes: ->> +>>=20 >>> This adds a few configurable debugging options: >>> >>> * driver debugging and tracing is now configurable per device @@ -11,26 +11,26 @@ Arend van Spriel <arend.vanspriel@broadcom.com> writes: >>> unless the specific debugging bitmap field is configured. >>> >>> Signed-off-by: Adrian Chadd <adrian@FreeBSD.org> ->> +>>=20 >> [...] ->> +>>=20 >>> --- a/drivers/net/wireless/ath/ath10k/core.c >>> +++ b/drivers/net/wireless/ath/ath10k/core.c >>> @@ -2444,6 +2444,8 @@ struct ath10k *ath10k_core_create(size_t >>> priv_size, struct device *dev, ->>> ar->hw_rev = hw_rev; ->>> ar->hif.ops = hif_ops; ->>> ar->hif.bus = bus; ->>> + ar->debug_mask = ath10k_debug_mask; ->>> + ar->trace_debug_mask = ath10k_debug_mask; ->> +>>> ar->hw_rev =3D hw_rev; +>>> ar->hif.ops =3D hif_ops; +>>> ar->hif.bus =3D bus; +>>> + ar->debug_mask =3D ath10k_debug_mask; +>>> + ar->trace_debug_mask =3D ath10k_debug_mask; +>>=20 >> Until now tracing has been always enabled, irrespective what debug_mask >> has contained. Now you are changing that and by default log messages are >> not delivered through tracing until user enables them. So I think to >> keep the old behaviour trace_debug_mask should be ATH10K_DBG_ANY >> (0xffffffff) by default and the user can modify the mask per device via >> the debugfs file. ->> +>>=20 >> But is it really needed to be able to filter trace messages? debug_mask >> I understand, but not sure about trace_debug_mask. > @@ -47,9 +47,5 @@ trace-cmd record -e mac80211 -e cfg80211 -e ath10k But if user is forced to use debugfs to enable ath10k tracing that is quite a step backwards. --- -Kalle Valo -_______________________________________________ -ath10k mailing list -ath10k@lists.infradead.org -http://lists.infradead.org/mailman/listinfo/ath10k +--=20 +Kalle Valo= diff --git a/a/content_digest b/N1/content_digest index 9a15b7a..3aacaef 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,15 +6,15 @@ "Date\0Thu, 1 Jun 2017 13:24:15 +0000\0" "To\0Arend van Spriel <arend.vanspriel@broadcom.com>\0" "Cc\0Adrian Chadd <adrian@freebsd.org>" - linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org> - " ath10k@lists.infradead.org <ath10k@lists.infradead.org>\0" + ath10k@lists.infradead.org <ath10k@lists.infradead.org> + " linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org>\0" "\00:1\0" "b\0" "Arend van Spriel <arend.vanspriel@broadcom.com> writes:\n" "\n" "> On 31-05-17 14:16, Kalle Valo wrote:\n" ">> Adrian Chadd <adrian@freebsd.org> writes:\n" - ">> \n" + ">>=20\n" ">>> This adds a few configurable debugging options:\n" ">>>\n" ">>> * driver debugging and tracing is now configurable per device\n" @@ -23,26 +23,26 @@ ">>> unless the specific debugging bitmap field is configured.\n" ">>>\n" ">>> Signed-off-by: Adrian Chadd <adrian@FreeBSD.org>\n" - ">> \n" + ">>=20\n" ">> [...]\n" - ">> \n" + ">>=20\n" ">>> --- a/drivers/net/wireless/ath/ath10k/core.c\n" ">>> +++ b/drivers/net/wireless/ath/ath10k/core.c\n" ">>> @@ -2444,6 +2444,8 @@ struct ath10k *ath10k_core_create(size_t\n" ">>> priv_size, struct device *dev,\n" - ">>> \tar->hw_rev = hw_rev;\n" - ">>> \tar->hif.ops = hif_ops;\n" - ">>> \tar->hif.bus = bus;\n" - ">>> +\tar->debug_mask = ath10k_debug_mask;\n" - ">>> +\tar->trace_debug_mask = ath10k_debug_mask;\n" - ">> \n" + ">>> \tar->hw_rev =3D hw_rev;\n" + ">>> \tar->hif.ops =3D hif_ops;\n" + ">>> \tar->hif.bus =3D bus;\n" + ">>> +\tar->debug_mask =3D ath10k_debug_mask;\n" + ">>> +\tar->trace_debug_mask =3D ath10k_debug_mask;\n" + ">>=20\n" ">> Until now tracing has been always enabled, irrespective what debug_mask\n" ">> has contained. Now you are changing that and by default log messages are\n" ">> not delivered through tracing until user enables them. So I think to\n" ">> keep the old behaviour trace_debug_mask should be ATH10K_DBG_ANY\n" ">> (0xffffffff) by default and the user can modify the mask per device via\n" ">> the debugfs file.\n" - ">> \n" + ">>=20\n" ">> But is it really needed to be able to filter trace messages? debug_mask\n" ">> I understand, but not sure about trace_debug_mask.\n" ">\n" @@ -59,11 +59,7 @@ "But if user is forced to use debugfs to enable ath10k tracing that is\n" "quite a step backwards.\n" "\n" - "-- \n" - "Kalle Valo\n" - "_______________________________________________\n" - "ath10k mailing list\n" - "ath10k@lists.infradead.org\n" - http://lists.infradead.org/mailman/listinfo/ath10k + "--=20\n" + Kalle Valo= -8c3a6aaab4f0cca5f901f9f3b7d8457b04e0d33b9cd20e342a9d19885ce2685d +f0306c079e3855d718848918c7904d3c05511b1416ff08aec2dd500a6bce1dcc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.