From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Vincent Palatin <vpalatin@chromium.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel'
Date: Wed, 03 May 2017 10:07:13 +0200 [thread overview]
Message-ID: <87r3065pou.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <64215e6a-ce86-073c-ae8c-08f3bf7d5615@redhat.com> (Paolo Bonzini's message of "Tue, 2 May 2017 18:22:50 +0200")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 02/05/2017 18:19, Thomas Huth wrote:
>>> I don't like writing it so often, especially to someone who is a
>>> relatively experienced contributor, but the common word in all these
>>> reviews is "pointless". What is the *purpose* of this work?
>>
>> Marking the -enable-xxx options in the documentation as deprecated would
>> maybe at least prevent that we end up with more
>> -enable-mynewcoolaccelerator options in the future, like we did with
>> -enable-hax now.
>
> That assumes -enable-hax was a mistake. :)
It was, or else -accel was a mistake.
>> But ok, I got the message, and I'll shut up here now. Sorry for wasting
>> your time.
>
> That absolutely wasn't the intent, sorry. The intent is to make your
> efforts more useful.
Seconded. I hope your patches and our discussion lead us towards a
saner, more consistent documented public interface.
next prev parent reply other threads:[~2017-05-03 8:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 10:06 [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel' Thomas Huth
2017-05-02 10:21 ` Daniel P. Berrange
2017-05-02 10:29 ` Thomas Huth
2017-05-02 10:32 ` Christian Borntraeger
2017-05-02 10:37 ` Thomas Huth
2017-05-02 10:48 ` Christian Borntraeger
2017-05-02 11:26 ` Thomas Huth
2017-05-02 11:59 ` Daniel P. Berrange
2017-05-02 12:07 ` Thomas Huth
2017-05-02 12:14 ` Thomas Huth
2017-05-02 12:16 ` Daniel P. Berrange
2017-05-02 12:38 ` Daniel P. Berrange
2017-05-02 12:46 ` Thomas Huth
2017-05-02 13:22 ` Paolo Bonzini
2017-05-02 15:01 ` Markus Armbruster
2017-05-02 15:09 ` Paolo Bonzini
2017-05-02 15:53 ` Thomas Huth
2017-05-02 16:08 ` Paolo Bonzini
2017-05-02 16:19 ` Thomas Huth
2017-05-02 16:22 ` Paolo Bonzini
2017-05-03 8:07 ` Markus Armbruster [this message]
2017-05-02 12:21 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3065pou.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.