From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/5] drm/i915: Fix condition check for backlight control via DPCD Date: Thu, 09 Mar 2017 11:50:18 +0200 Message-ID: <87r326hj8l.fsf@intel.com> References: <20170308213053.194062-1-puthik@chromium.org> <20170308213053.194062-2-puthik@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id B735B6EB9B for ; Thu, 9 Mar 2017 09:50:23 +0000 (UTC) In-Reply-To: <20170308213053.194062-2-puthik@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Puthikorn Voravootivat List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAwOCBNYXIgMjAxNywgUHV0aGlrb3JuIFZvcmF2b290aXZhdCA8cHV0aGlrQGNocm9t aXVtLm9yZz4gd3JvdGU6Cj4gQ3VycmVudGx5IHRoZSBpbnRlbF9kcF9hdXhfYmFja2xpZ2h0IGRy aXZlciByZXF1aXJlcyBlRFAgcGFuZWwKPiB0byBzdXBwb3J0IHRoZXNlIGNvbmRpdGlvbnMgdG8g YWxsb3cgdGhlIGJhY2tsaWdodCBhZGp1c3QgdmlhCj4gZHBjZCByZWdpc3Rlci4KPiAxKSBEUF9F RFBfVENPTl9CQUNLTElHSFRfQURKVVNUTUVOVF9DQVAKPiAyKSBEUF9FRFBfQkFDS0xJR0hUX0FV WF9FTkFCTEVfQ0FQCj4gMykgbm90IERQX0VEUF9CQUNLTElHSFRfUElOX0VOQUJMRV9DQVAKPiA0 KSBub3QgRFBfRURQX0JBQ0tMSUdIVF9CUklHSFRORVNTX1BXTV9QSU5fQ0FQCj4KPiBDb25kaXRp b24gMiwzLDQgYXJlIGluY29yZWN0IGJlY2F1c2Ugb2YgdGhlIGZvbGxvd2luZyByZWFzb25zLgo+ IEZvciAyKSwgImJhY2tsaWdodCBjYW4gYmUgZW5hYmxlZCB2aWEgQVVYIiBpcyBub3QgImJyaWdo dG5lc3MKPiBjYW4gYmUgYWRqdXN0ZWQgdmlhIEFVWCIuIEZvciAzKSBhbmQgNCksIHRoaXMgcmVx dWlyZXMgcGFuZWwKPiB0byBub3Qgc3VwcG9ydCBiYWNrbGlnaHQgYWRqdXN0bWVudCB2aWEgZURQ IEJMX1BXTV9ESU0gcGluLAo+IGJ1dCB0aGVyZSBhcmUgc29tZSBwYW5lbHMgdGhhdCBzdXBwb3J0 IGJvdGggQVVYIGFuZCBlRFAgcGluLgo+Cj4gVGhpcyBwYXRjaCBmaXhlcyB0aGUgY29uZGl0aW9u IGJ5IGNoZWNraW5nIGZvciB0aGVzZSBpbnN0ZWFkLgo+IDEpIERQX0VEUF9UQ09OX0JBQ0tMSUdI VF9BREpVU1RNRU5UX0NBUAo+IDIpIERQX0VEUF9CQUNLTElHSFRfQlJJR0hUTkVTU19BVVhfU0VU X0NBUAoKSSB1bmRlcnN0YW5kIHlvdXIgcG9pbnQsIGJ1dCBJSVJDIHRoZSBnb2FsIHdpdGggdGhl IGN1cnJlbnQgY29kZSB3YXMgdG8Kc3VwcG9ydCBEUENEIGJhY2tsaWdodCBjb250cm9sICpvbmx5 KiB3aGVuIFBXTSBwaW4gYmFja2xpZ2h0IGNvbnRyb2wgd2FzCm5vdCBwb3NzaWJsZS4gWW91ciBw YXRjaCB0dXJucyBpdCBhcm91bmQsIGFuZCBlbmFibGVzIERQQ0QgYmFja2xpZ2h0CmNvbnRyb2wg d2hlbmV2ZXIgaXQncyBwb3NzaWJsZS4KCj4gVGhpcyBwYXRjaCBhbHNvIGFkZCBhIGNoZWNrIHRv IERQX0VEUF9CQUNLTElHSFRfQVVYX0VOQUJMRV9DQVAKPiBpbiBzZXRfYXV4X2JhY2tsaWdodF9l bmFibGUoKSBzaW5jZSB0aGUgYmFja2xpZ2h0IGVuYWJsZW1lbnQKPiBjYW4gYmUgZG9uZSB2aWEg QkxfRU5BQkxFIGVEUCBjb25uZWN0b3IgcGluIGluIHRoZSBjYXNlIHRoYXQKPiBpdCBkb2VzIG5v dCBzdXBwb3J0IGRvaW5nIHRoYXQgdmlhIEFVWC4KCkl0J3MgYWxzbyB0cnVlIHRoYXQgdGhlIGN1 cnJlbnQgY29kZSBjb25mbGF0ZXMgYmFja2xpZ2h0IGVuYWJsZSBhbmQKYWRqdXN0bWVudCBjYXBz LiBCdXQgdGhhdCdzIGxhcmdlbHkgYmVjYXVzZSB3ZSBhbHNvIGN1cnJlbnRseSBkbyBub3QKc3Vw cG9ydCBhbnkgdHlwZSBvZiBtaXhlZCBtb2RlLiBBbmQgdGhhdCB3b3VsZCByZXF1aXJlIHF1aXRl IGEgYml0IG1vcmUKY29kZS4gV2l0aCB5b3VyIHBhdGNoLCB5b3UgY291bGQgZW5kIHVwIHdpdGgg RFBDRCBiYWNrbGlnaHQgYWRqdXN0bWVudAp3aXRoIG5vIGJhY2tsaWd0IGVuYWJsZS9kaXNhYmxl IGNhcGFiaWxpdHkuCgpTbyBJIGFja25vd2xlZGdlIHRoZSBsaW1pdGF0aW9ucyBpbiB0aGUgY3Vy cmVudCBjb2RlLCBidXQgSSdtIGFsc28gbm90CmNvbnZpbmNlZCB0aGlzIHBhdGNoIHNlcmllcyB3 b3VsZCBiZSBzdWZmaWNpZW50LgoKCkJSLApKYW5pLgoKPgo+IFNpZ25lZC1vZmYtYnk6IFB1dGhp a29ybiBWb3Jhdm9vdGl2YXQgPHB1dGhpa0BjaHJvbWl1bS5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYyB8IDEwICsrKysrKy0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPiBpbmRleCA2NTMy ZTIyNmRiMjkuLmFiZmIwOWMxMjY5ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPiBAQCAtMjgsNiArMjgsMTAgQEAgc3RhdGljIHZvaWQg c2V0X2F1eF9iYWNrbGlnaHRfZW5hYmxlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGJvb2wg ZW5hYmxlKQo+ICB7Cj4gIAl1aW50OF90IHJlZ192YWwgPSAwOwo+ICAKPiArCS8qIEVhcmx5IHJl dHVybiB3aGVuIGRpc3BsYXkgdXNlIG90aGVyIG1lY2hhbmlzbSB0byBlbmFibGUgYmFja2xpZ2h0 LiAqLwo+ICsJaWYgKCEoaW50ZWxfZHAtPmVkcF9kcGNkWzFdICYgRFBfRURQX0JBQ0tMSUdIVF9B VVhfRU5BQkxFX0NBUCkpCj4gKwkJcmV0dXJuOwo+ICsKPiAgCWlmIChkcm1fZHBfZHBjZF9yZWFk YigmaW50ZWxfZHAtPmF1eCwgRFBfRURQX0RJU1BMQVlfQ09OVFJPTF9SRUdJU1RFUiwKPiAgCQkJ ICAgICAgJnJlZ192YWwpIDwgMCkgewo+ICAJCURSTV9ERUJVR19LTVMoIkZhaWxlZCB0byByZWFk IERQQ0QgcmVnaXN0ZXIgMHgleFxuIiwKPiBAQCAtMTQyLDEwICsxNDYsOCBAQCBpbnRlbF9kcF9h dXhfZGlzcGxheV9jb250cm9sX2NhcGFibGUoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVj dG9yKQo+ICAJLyogQ2hlY2sgdGhlICBlRFAgRGlzcGxheSBjb250cm9sIGNhcGFiaWxpdGllcyBy ZWdpc3RlcnMgdG8gZGV0ZXJtaW5lIGlmCj4gIAkgKiB0aGUgcGFuZWwgY2FuIHN1cHBvcnQgYmFj a2xpZ2h0IGNvbnRyb2wgb3ZlciB0aGUgYXV4IGNoYW5uZWwKPiAgCSAqLwo+IC0JaWYgKGludGVs X2RwLT5lZHBfZHBjZFsxXSAmIERQX0VEUF9UQ09OX0JBQ0tMSUdIVF9BREpVU1RNRU5UX0NBUCAm Jgo+IC0JICAgIChpbnRlbF9kcC0+ZWRwX2RwY2RbMV0gJiBEUF9FRFBfQkFDS0xJR0hUX0FVWF9F TkFCTEVfQ0FQKSAmJgo+IC0JICAgICEoKGludGVsX2RwLT5lZHBfZHBjZFsxXSAmIERQX0VEUF9C QUNLTElHSFRfUElOX0VOQUJMRV9DQVApIHx8Cj4gLQkgICAgICAoaW50ZWxfZHAtPmVkcF9kcGNk WzJdICYgRFBfRURQX0JBQ0tMSUdIVF9CUklHSFRORVNTX1BXTV9QSU5fQ0FQKSkpIHsKPiArCWlm ICgoaW50ZWxfZHAtPmVkcF9kcGNkWzFdICYgRFBfRURQX1RDT05fQkFDS0xJR0hUX0FESlVTVE1F TlRfQ0FQKSAmJgo+ICsJICAgIChpbnRlbF9kcC0+ZWRwX2RwY2RbMl0gJiBEUF9FRFBfQkFDS0xJ R0hUX0JSSUdIVE5FU1NfQVVYX1NFVF9DQVApKSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygiQVVYIEJh Y2tsaWdodCBDb250cm9sIFN1cHBvcnRlZCFcbiIpOwo+ICAJCXJldHVybiB0cnVlOwo+ICAJfQoK LS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK