Re: [PATCH 03/30] usb: dwc2: gadget: Add descriptor DMA binding

[Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]

John Youn <johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org> writes:

> From: Vahram Aharonyan <vahrama-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
>
> Add the devicetree binding to enable descriptor DMA and read it in to
> the corresponding parameter during probe.
>
> Signed-off-by: Vahram Aharonyan <vahrama-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
> Signed-off-by: John Youn <johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/usb/dwc2.txt |  1 +
>  drivers/usb/dwc2/core.h                        |  4 ++++
>  drivers/usb/dwc2/gadget.c                      | 11 +++++++++++
>  drivers/usb/dwc2/params.c                      |  4 ++++
>  4 files changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt
> index 389a461..1db9c37 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc2.txt
> @@ -27,6 +27,7 @@ Refer to phy/phy-bindings.txt for generic phy consumer properties
>    Refer to usb/generic.txt
>  - snps,host-dma-disable: disable host DMA mode.
>  - snps,gadget-dma-enable: enable gadget DMA mode.
> +- snps,gadget-dma-desc-enable: enable gadget DMA descriptor mode.

seems to be discoverable as well:

#define GHWCFG4_DESC_DMA_DYN			(1 << 31)
#define GHWCFG4_DESC_DMA			(1 << 30)

care to comment?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]