Re: [Qemu-devel] [PATCH] mttcg: Handle EXCP_ATOMIC exception

[Pranith Kumar <bobby.prani@gmail.com>]

Alex Bennée writes:

> Pranith Kumar <bobby.prani@gmail.com> writes:
>
>> The patch enables handling atomic code in the guest. This should be
>> preferably done in cpu_handle_exception(), but the current assumptions
>> regarding when we can execute atomic sections cause a deadlock.
>>
>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>> ---
>>  cpus.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/cpus.c b/cpus.c
>> index 8f98060..c4ba7d8 100644
>> --- a/cpus.c
>> +++ b/cpus.c
>> @@ -1315,6 +1315,9 @@ static void *qemu_tcg_rr_cpu_thread_fn(void *arg)
>>                  if (r == EXCP_DEBUG) {
>>                      cpu_handle_guest_debug(cpu);
>>                      break;
>> +                } else if (r == EXCP_ATOMIC) {
>> +                    cpu_exec_step_atomic(cpu);
>> +                    break;
>
> Hmm don't we need to unlock the iothread here as well? I suspect you
> never see a deadlock because the rr thread can't by definition race with
> itself but the locking practice should be the same for both cases.
>

Yes, not having any other thread to race with is the reason I did not unlock
the iothread. But, I agree that the semantics need to be the same.

I will send an updated patch.

Thanks,
-- 
Pranith