From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1c1GDN-0008WI-M0
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:17:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1c1GDK-0005ig-Hd
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:17:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55818)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <quintela@redhat.com>) id 1c1GDK-0005iY-C5
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:17:38 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1477824430-1460-11-git-send-email-amit.shah@redhat.com> (Amit
	Shah's message of "Sun, 30 Oct 2016 16:17:02 +0530")
References: <1477824430-1460-1-git-send-email-amit.shah@redhat.com>
	<1477824430-1460-11-git-send-email-amit.shah@redhat.com>
Reply-To: quintela@redhat.com
Date: Mon, 31 Oct 2016 18:17:34 +0100
Message-ID: <87r36wbfpt.fsf@emacs.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PULL 10/18] COLO: Add checkpoint-delay parameter
 for migrate-set-parameters
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu list <qemu-devel@nongnu.org>, zhang.zhanghailiang@huawei.com

Amit Shah <amit.shah@redhat.com> wrote:
> From: zhanghailiang <zhang.zhanghailiang@huawei.com>
>
> Add checkpoint-delay parameter for migrate-set-parameters, so that
> we can control the checkpoint frequency when COLO is in periodic mode.
>
>  
> @@ -587,6 +593,7 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp)
>      params->max_bandwidth = s->parameters.max_bandwidth;
>      params->has_downtime_limit = true;
>      params->downtime_limit = s->parameters.downtime_limit;
> +    params->x_checkpoint_delay = s->parameters.x_checkpoint_delay;
>  
>      return params;
>  }

I think you are missing here:

params->has_x_checkpoint_delay = true;

No?

Later, Juan