From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn2XZ-0004w4-GX for qemu-devel@nongnu.org; Thu, 22 Sep 2016 07:51:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn2XT-0006b9-Qr for qemu-devel@nongnu.org; Thu, 22 Sep 2016 07:51:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn2XT-0006b0-Kg for qemu-devel@nongnu.org; Thu, 22 Sep 2016 07:51:39 -0400 From: Markus Armbruster References: <000301d213c7$7142f980$53c8ec80$@ru> <87y42l93dr.fsf@dusky.pond.sub.org> <20160921100718.GO15535@redhat.com> <87mvj11ljr.fsf@dusky.pond.sub.org> <7500849B-8BCC-4743-92A6-5DBD4D8575E8@nutanix.com> <20160921143546.GS15535@redhat.com> <87zin1w9v4.fsf@dusky.pond.sub.org> <20160922080004.GB352@redhat.com> Date: Thu, 22 Sep 2016 13:51:36 +0200 In-Reply-To: <20160922080004.GB352@redhat.com> (Daniel P. Berrange's message of "Thu, 22 Sep 2016 09:00:04 +0100") Message-ID: <87r38cjgon.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Eric Blake , qemu-devel , Pavel Dovgalyuk , Pavel Dovgalyuk , Felipe Franciosi "Daniel P. Berrange" writes: > On Wed, Sep 21, 2016 at 01:18:58PM -0500, Eric Blake wrote: >> On 09/21/2016 10:28 AM, Markus Armbruster wrote: >> >> >> The compiler.h file has no license header, just a comment >> >> saying "public domain", which is obviously not the case >> >> if you add this macro. >> >> >> >> Given that you'll need to explicitly mention the license terms >> >> for ignore_value. eg with a comment line like >> >> >> >> /* The ignore_value() macro is taken from GNULIB ignore-value.h, >> >> * licensed under the terms of the LGPLv2+ >> >> */ >> > >> > Our tree has a mix of licenses, which is enough of a pain. Mixing >> > licenses within *files* is even worse, and might not even be legally >> > sound. >> > >> > Relicense the whole file under our preferred license GPLv2+? >> >> That works too. No one can legally complain - the current license is so >> permissive that marking the entire file LGPLv2+ is permitted by the >> current license. It's a one-way conversion (we can't go back once we do >> it), but I would be fine with that approach. > > I think the file probably should not have been listed as public domain > in the first place, as its initial contents were copied from qemu-common.h > which is not public domain. Ewww! Needs fixing. Since qemu-common.h carries no license, GPLv2+ applies.