From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 15/21] drm/i915: Reorder i915_add_request to separate the phases better Date: Tue, 06 Sep 2016 12:36:51 +0300 Message-ID: <87r38x8j4c.fsf@gaia.fi.intel.com> References: <20160905130438.31046-1-chris@chris-wilson.co.uk> <20160905130438.31046-16-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4A286E56A for ; Tue, 6 Sep 2016 09:38:47 +0000 (UTC) In-Reply-To: <20160905130438.31046-16-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gTGV0J3Mg YXZvaWQgbWl4aW5nIHNlYWxpbmcgdGhlIGhhcmR3YXJlIGNvbW1hbmRzIGZvciB0aGUgcmVxdWVz dCBhbmQKPiBhZGRpbmcgdGhlIHJlcXVlc3QgdG8gdGhlIHNvZnR3YXJlIHRyYWNraW5nLgo+Cj4g U2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+CgpS ZXZpZXdlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMgfCAyOCArKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCsp LCAxNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9yZXF1ZXN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0 LmMKPiBpbmRleCBjNjBhN2I3NzRjYzYuLjM0NTcxZTFlYjMyOCAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMKPiBAQCAtNDkyLDYgKzQ5Miw4IEBAIHZvaWQgX19p OTE1X2FkZF9yZXF1ZXN0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCwgYm9v bCBmbHVzaF9jYWNoZXMpCj4gIAl1MzIgcmVzZXJ2ZWRfdGFpbDsKPiAgCWludCByZXQ7Cj4gIAo+ ICsJdHJhY2VfaTkxNV9nZW1fcmVxdWVzdF9hZGQocmVxdWVzdCk7Cj4gKwo+ICAJLyoKPiAgCSAq IFRvIGVuc3VyZSB0aGF0IHRoaXMgY2FsbCB3aWxsIG5vdCBmYWlsLCBzcGFjZSBmb3IgaXRzIGVt aXNzaW9ucwo+ICAJICogc2hvdWxkIGFscmVhZHkgaGF2ZSBiZWVuIHJlc2VydmVkIGluIHRoZSBy aW5nIGJ1ZmZlci4gTGV0IHRoZSByaW5nCj4gQEAgLTUxNSwyMCArNTE3LDYgQEAgdm9pZCBfX2k5 MTVfYWRkX3JlcXVlc3Qoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0LCBib29s IGZsdXNoX2NhY2hlcykKPiAgCQlXQVJOKHJldCwgImVuZ2luZS0+ZW1pdF9mbHVzaCgpIGZhaWxl ZDogJWQhXG4iLCByZXQpOwo+ICAJfQo+ICAKPiAtCXRyYWNlX2k5MTVfZ2VtX3JlcXVlc3RfYWRk KHJlcXVlc3QpOwo+IC0KPiAtCS8qIFNlYWwgdGhlIHJlcXVlc3QgYW5kIG1hcmsgaXQgYXMgcGVu ZGluZyBleGVjdXRpb24uIE5vdGUgdGhhdAo+IC0JICogd2UgbWF5IGluc3BlY3QgdGhpcyBzdGF0 ZSwgd2l0aG91dCBob2xkaW5nIGFueSBsb2NrcywgZHVyaW5nCj4gLQkgKiBoYW5nY2hlY2suIEhl bmNlIHdlIGFwcGx5IHRoZSBiYXJyaWVyIHRvIGVuc3VyZSB0aGF0IHdlIGRvIG5vdAo+IC0JICog c2VlIGEgbW9yZSByZWNlbnQgdmFsdWUgaW4gdGhlIGh3cyB0aGFuIHdlIGFyZSB0cmFja2luZy4K PiAtCSAqLwo+IC0JcmVxdWVzdC0+ZW1pdHRlZF9qaWZmaWVzID0gamlmZmllczsKPiAtCXJlcXVl c3QtPnByZXZpb3VzX3NlcW5vID0gZW5naW5lLT5sYXN0X3N1Ym1pdHRlZF9zZXFubzsKPiAtCWVu Z2luZS0+bGFzdF9zdWJtaXR0ZWRfc2Vxbm8gPSByZXF1ZXN0LT5mZW5jZS5zZXFubzsKPiAtCWk5 MTVfZ2VtX2FjdGl2ZV9zZXQoJmVuZ2luZS0+bGFzdF9yZXF1ZXN0LCByZXF1ZXN0KTsKPiAtCWxp c3RfYWRkX3RhaWwoJnJlcXVlc3QtPmxpbmssICZlbmdpbmUtPnJlcXVlc3RfbGlzdCk7Cj4gLQls aXN0X2FkZF90YWlsKCZyZXF1ZXN0LT5yaW5nX2xpbmssICZyaW5nLT5yZXF1ZXN0X2xpc3QpOwo+ IC0KPiAgCS8qIFJlY29yZCB0aGUgcG9zaXRpb24gb2YgdGhlIHN0YXJ0IG9mIHRoZSBicmVhZGNy dW1iIHNvIHRoYXQKPiAgCSAqIHNob3VsZCB3ZSBkZXRlY3QgdGhlIHVwZGF0ZWQgc2Vxbm8gcGFy dC13YXkgdGhyb3VnaCB0aGUKPiAgCSAqIEdQVSBwcm9jZXNzaW5nIHRoZSByZXF1ZXN0LCB3ZSBu ZXZlciBvdmVyLWVzdGltYXRlIHRoZQo+IEBAIC01NDksNiArNTM3LDE4IEBAIHZvaWQgX19pOTE1 X2FkZF9yZXF1ZXN0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCwgYm9vbCBm bHVzaF9jYWNoZXMpCj4gIAkJICAiZm9yIGFkZGluZyB0aGUgcmVxdWVzdCAoJWQgYnl0ZXMpXG4i LAo+ICAJCSAgcmVzZXJ2ZWRfdGFpbCwgcmV0KTsKPiAgCj4gKwkvKiBTZWFsIHRoZSByZXF1ZXN0 IGFuZCBtYXJrIGl0IGFzIHBlbmRpbmcgZXhlY3V0aW9uLiBOb3RlIHRoYXQKPiArCSAqIHdlIG1h eSBpbnNwZWN0IHRoaXMgc3RhdGUsIHdpdGhvdXQgaG9sZGluZyBhbnkgbG9ja3MsIGR1cmluZwo+ ICsJICogaGFuZ2NoZWNrLiBIZW5jZSB3ZSBhcHBseSB0aGUgYmFycmllciB0byBlbnN1cmUgdGhh dCB3ZSBkbyBub3QKPiArCSAqIHNlZSBhIG1vcmUgcmVjZW50IHZhbHVlIGluIHRoZSBod3MgdGhh biB3ZSBhcmUgdHJhY2tpbmcuCj4gKwkgKi8KPiArCXJlcXVlc3QtPmVtaXR0ZWRfamlmZmllcyA9 IGppZmZpZXM7Cj4gKwlyZXF1ZXN0LT5wcmV2aW91c19zZXFubyA9IGVuZ2luZS0+bGFzdF9zdWJt aXR0ZWRfc2Vxbm87Cj4gKwllbmdpbmUtPmxhc3Rfc3VibWl0dGVkX3NlcW5vID0gcmVxdWVzdC0+ ZmVuY2Uuc2Vxbm87Cj4gKwlpOTE1X2dlbV9hY3RpdmVfc2V0KCZlbmdpbmUtPmxhc3RfcmVxdWVz dCwgcmVxdWVzdCk7Cj4gKwlsaXN0X2FkZF90YWlsKCZyZXF1ZXN0LT5saW5rLCAmZW5naW5lLT5y ZXF1ZXN0X2xpc3QpOwo+ICsJbGlzdF9hZGRfdGFpbCgmcmVxdWVzdC0+cmluZ19saW5rLCAmcmlu Zy0+cmVxdWVzdF9saXN0KTsKPiArCj4gIAlpOTE1X2dlbV9tYXJrX2J1c3koZW5naW5lKTsKPiAg Cj4gIAlsb2NhbF9iaF9kaXNhYmxlKCk7Cj4gLS0gCj4gMi45LjMKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==