From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45145)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bgvLJ-0001cP-Kq
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 10:57:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bgvLF-0008Mq-BN
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 10:57:48 -0400
Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:35469)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bgvLF-0008Mf-5V
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 10:57:45 -0400
Received: by mail-wm0-x229.google.com with SMTP id w2so125990523wmd.0
	for <qemu-devel@nongnu.org>; Mon, 05 Sep 2016 07:57:44 -0700 (PDT)
References: <1472725227-10374-1-git-send-email-pbonzini@redhat.com>
	<1472725227-10374-10-git-send-email-pbonzini@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1472725227-10374-10-git-send-email-pbonzini@redhat.com>
Date: Mon, 05 Sep 2016 15:57:42 +0100
Message-ID: <87r38yz95l.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 09/12] cpus-common: always defer
 async_run_on_cpu work items
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Sergey Fedorov <serge.fdrv@gmail.com>, Sergey Fedorov <sergey.fedorov@linaro.org>, "Emilio G. Cota" <cota@braap.org>


Paolo Bonzini <pbonzini@redhat.com> writes:

> async_run_on_cpu is only called from the I/O thread, not from CPU threads,
> so it doesn't make any difference.  It will make a difference however
> for async_safe_run_on_cpu.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  cpus-common.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/cpus-common.c b/cpus-common.c
> index 47f7c06..59c8dc8 100644
> --- a/cpus-common.c
> +++ b/cpus-common.c
> @@ -136,11 +136,6 @@ void async_run_on_cpu(CPUState *cpu, run_on_cpu_func func, void *data)
>  {
>      struct qemu_work_item *wi;
>
> -    if (qemu_cpu_is_self(cpu)) {
> -        func(cpu, data);
> -        return;
> -    }
> -
>      wi = g_malloc0(sizeof(struct qemu_work_item));
>      wi->func = func;
>      wi->data = data;

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

--
Alex Bennée