From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNjZB-0001Vy-QD for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:32:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNjZ8-0003rl-JI for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:32:49 -0400 From: Markus Armbruster References: <1468484058-8719-1-git-send-email-thuth@redhat.com> <5787A27B.8020703@redhat.com> Date: Thu, 14 Jul 2016 18:32:43 +0200 In-Reply-To: <5787A27B.8020703@redhat.com> (Eric Blake's message of "Thu, 14 Jul 2016 08:32:27 -0600") Message-ID: <87r3awkwno.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Thomas Huth , qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, qemu-devel@nongnu.org Eric Blake writes: > On 07/14/2016 02:14 AM, Thomas Huth wrote: >> No need to include error-report.h twice here. >> >> Signed-off-by: Thomas Huth >> --- >> target-ppc/mmu-hash64.c | 1 - >> 1 file changed, 1 deletion(-) > > Reviewed-by: Eric Blake > > Markus, do your header cleanup scripts detect any other situations like > this? Not yet. Here's how I'd eliminate double inclusion. Step 1: make our own headers includable in any order. Step 2: include them in alphabetical order. The duplicates become obvious, and get dropped. Step 3: tell the lazy bums adding includes in the wrong place to mend their ways. I'm knee-deep in step 1.