From: ebiederm@xmission.com (Eric W. Biederman)
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Phil Sutter <phil@nwl.cc>,
Stephen Hemminger <shemming@brocade.com>,
netdev@vger.kernel.org
Subject: Re: [iproute PATCHv2 0/2] Netns performance improvements
Date: Thu, 07 Jul 2016 00:09:33 -0500 [thread overview]
Message-ID: <87r3b63ugi.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20160706212257.4e35d0fb@xeon-e3> (Stephen Hemminger's message of "Wed, 6 Jul 2016 21:22:57 -0700")
Stephen Hemminger <stephen@networkplumber.org> writes:
> On Tue, 5 Jul 2016 16:51:18 +0200
> Phil Sutter <phil@nwl.cc> wrote:
>
>> Stress-testing OpenStack Neutron revealed poor performance of 'ip netns'
>> when dealing with a high amount of namespaces. The cause of this lies in
>> the combination of how iproute2 mounts NETNS_RUN_DIR and the netns files
>> therein and the fact that systemd makes all mount points of the system
>> shared.
>>
>> Changes since v1:
>> - Added Suggested-by tag to patches.
>>
>> Phil Sutter (2):
>> ipnetns: Move NETNS_RUN_DIR into it's own propagation group
>> ipnetns: Make netns mount points private
>>
>> ip/ipnetns.c | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>
> I want an ack for Eric on this, it seems a little risky
If I have read the tea leaves properly the first patch is fighting
a system configuration of "mount --rbind /run /var/run" which seems
inappropriate. A symlink is likely a better fix.
The effect of the second patch is probably better had by performing the
optimization in the kernel, so everyone gets the benefit.
I am persuadable to change this behavior. But if all we are doing is
optimization and not intentionally changing the semantics there appear
to be better places for the optimizations to happen.
Eric
prev parent reply other threads:[~2016-07-07 5:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 14:51 [iproute PATCHv2 0/2] Netns performance improvements Phil Sutter
2016-07-05 14:51 ` [iproute PATCHv2 1/2] ipnetns: Move NETNS_RUN_DIR into it's own propagation group Phil Sutter
2016-07-05 14:51 ` [iproute PATCHv2 2/2] ipnetns: Make netns mount points private Phil Sutter
2016-07-07 4:22 ` [iproute PATCHv2 0/2] Netns performance improvements Stephen Hemminger
2016-07-07 5:09 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3b63ugi.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.