From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Thu, 23 Jun 2016 15:59:49 +0300 Message-ID: <87r3bohxh6.fsf@intel.com> References: <1464638381.2240.3.camel@HansenPartnership.com> <871t4ibr7k.fsf@intel.com> <1464701638.2234.1.camel@HansenPartnership.com> <87mvmp9z03.fsf@intel.com> <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <1466686369.6831.1.camel@snewbury.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1466686369.6831.1.camel@snewbury.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Steven Newbury , James Bottomley , Daniel Vetter Cc: intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMyBKdW4gMjAxNiwgU3RldmVuIE5ld2J1cnkgPHN0ZXZlQHNuZXdidXJ5Lm9yZy51 az4gd3JvdGU6Cj4gWyBVbmtub3duIHNpZ25hdHVyZSBzdGF0dXMgXQo+IE9uIFN1biwgMjAxNi0w Ni0xOSBhdCAxNDo1MyAtMDcwMCwgSmFtZXMgQm90dG9tbGV5IHdyb3RlOgo+PiBPbiBGcmksIDIw MTYtMDYtMTcgYXQgMTY6MDYgLTA3MDAsIEphbWVzIEJvdHRvbWxleSB3cm90ZToKPj4gPiBPbiBG cmksIDIwMTYtMDYtMTcgYXQgMTY6MzQgKzAzMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+PiA+ID4g T24gRnJpLCAxNyBKdW4gMjAxNiwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPj4gPiA+ID4gT24gVGh1LCBKdW4gMTYsIDIwMTYgYXQgMDM6NDI6MTJQTSAtMDcwMCwgSmFt ZXMgQm90dG9tbGV5Cj4+ID4gPiA+IHdyb3RlOgo+PiA+ID4gPiA+IE9uIFRodSwgMjAxNi0wNi0x NiBhdCAxNDoyOSAtMDcwMCwgSmFtZXMgQm90dG9tbGV5IHdyb3RlOgo+PiA+ID4gPiA+ID4gT24g VGh1LCAyMDE2LTA2LTE2IGF0IDIzOjI0ICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+PiA+ ID4gPiA+ID4gPiBJIGd1ZXNzIHdlJ2xsIG5lZWQgdGhlIGJpc2VjdCBvbiB0aGlzIG9uZSB0byBt YWtlCj4+ID4gPiA+ID4gPiA+IHByb2dyZXNzLgo+PiA+ID4gPiA+ID4gCj4+ID4gPiA+ID4gPiBT aWdoLCBJIHdhcyBhZnJhaWQgdGhhdCBtaWdodCBiZSB0aGUgbmV4dCBzdGVwLgo+PiA+ID4gPiA+ IAo+PiA+ID4gPiA+IE9LLCBJIGhhdmUgYSBjdXJpb3VzIGRhdGEgcG9pbnQuwqDCoEkgYXNzdW1l ZCB0aGUgcHJvYmxlbSB3b3VsZAo+PiA+ID4gPiA+IGJlCj4+ID4gPiA+ID4gc29tZXdoZXJlIGlu IHRoZSBkcm0gdXBkYXRlLCBzbyBJIHN0YXJ0ZWQgYmlzZWN0aW5nIHRoYXQgYXQKPj4gPiA+ID4g PiB0aGUKPj4gPiA+ID4gPiB0b3AuwqAKPj4gPiA+ID4gPiDCoEhvd2V2ZXIsIHRoZSB0b3AgbW9z dCBjb21taXQ6Cj4+ID4gPiA+ID4gCj4+ID4gPiA+ID4gY29tbWl0IDFkNmRhODdhMzI0MWRlYjEz ZDA3M2M0MTI1ZDE5ZWQwZTVhMGM2MmMKPj4gPiA+ID4gPiBNZXJnZTogMWY0MGM0OSBhMzllZDY4 Cj4+ID4gPiA+ID4gQXV0aG9yOiBMaW51cyBUb3J2YWxkcyA8dG9ydmFsZHNAbGludXgtZm91bmRh dGlvbi5vcmc+Cj4+ID4gPiA+ID4gRGF0ZTrCoMKgwqBNb24gTWF5IDIzIDExOjQ4OjQ4IDIwMTYg LTA3MDAKPj4gPiA+ID4gPiAKPj4gPiA+ID4gPiDCoMKgwqDCoE1lcmdlIGJyYW5jaCAnZHJtLW5l eHQnIG9mCj4+ID4gPiA+ID4gZ2l0Oi8vcGVvcGxlLmZyZWVkZXNrdG9wLm9yZy9+YWlybGllZC9s aW51eAo+PiA+ID4gPiA+IAo+PiA+ID4gPiA+IElzbid0IGFjdHVhbGx5IGJhZC7CoMKgVGhlcmUn cyBubyBmbGlja2VyIGhlcmUsIHNvIHdoYXRldmVyCj4+ID4gPiA+ID4gY2F1c2VkCj4+ID4gPiA+ ID4gdGhlCj4+ID4gPiA+ID4gcHJvYmxlbSBjYW1lIGZyb20gc29tZSB1cGRhdGUgYWZ0ZXIgdGhp cy4KPj4gPiA+ID4gCj4+ID4gPiA+IFRoZXJlIHdhcyBhIGZpeGVzIHB1bGwgYWZ0ZXIgdGhpcy4g TWlnaHQgYmUgd29ydGggaXQgdG8KPj4gPiA+ID4gcmVzdHJpY3QKPj4gPiA+ID4gdG8KPj4gPiA+ ID4ganVzdAo+PiA+ID4gPiB0aGUgaTkxNSBjaGFuZ2VzLCB3aGljaCBhcmUganVzdAo+PiA+ID4g PiA1YjRmZDViMTExMWIxMjMwY2QwMzcuLjE1N2QyYzdmYWQwODYzMjIyCj4+ID4gPiA+IAo+PiA+ ID4gPiBMb29raW5nIGF0IHRob3NlIG5vdGhpbmcgc2VlbXMgdG8gc3RpY2sgb3V0IHdoaWNoIG1p Z2h0IGV4cGxhaW4KPj4gPiA+ID4gd2hhdCdzCj4+ID4gPiA+IGhhcHBlbmluZyBmb3IgeW91Lgo+ PiA+IAo+PiA+IE9LLCBzbyBqdXN0IG9uIHRoZSBmaXJtd2FyZSwgdGhlIHN5c3RlbSBzZWVtcyBs ZXNzIGZsaWNrZXJ5IHdpdGgKPj4gPiB0aGUKPj4gPiBuZXcgMS40LjMgVUVGSSwgc28gSSdtIHN0 YXJ0aW5nIHRvIHRoaW5rIGl0IGlzIGEgU2t5bGFrZSBlcnJhdGHCoAo+PiA+IGlzc3VlLsKgwqBU aGUgZmxpY2tlciBpc24ndCBnb25lIGZvciBnb29kLCBidXQgc2VlbXMgdG8gYmUgcmVib290wqAK Pj4gPiBkZXBlbmRlbnQgKGl0J3MgdGhlcmUgaW4gc29tZSBib290cywgYnV0IGdvbmUgb24gYSBy ZWJvb3QpLgo+PiA+IAo+PiA+ID4gVGhpcyBzaG91bGQgYmUgZWFzeSBlbm91Z2ggdG8gdHJ5IGJl Zm9yZSBiaXNlY3Rpbmc6Cj4+ID4gPiBodHRwOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9w YXRjaC9tc2dpZC8xNDY2MTYyMDgxLTEyMDQyLTEtZwo+PiA+ID4gaXQKPj4gPiA+IC1zCj4+ID4g PiBlbmQtZW1haWwtbWlrYS5rYWhvbGFAaW50ZWwuY29tCj4+ID4gCj4+ID4gQXBwbHlpbmcgdGhp cyBkaWRuJ3Qgc2VlbSB0byBtYWtlIGEgZGlmZmVyZW5jZTogc3RpbGwgdGhlcmUgb24KPj4gPiBz b21lwqAKPj4gPiBhbmQgZ29uZSBvbiBvdGhlciByZWJvb3RzLgo+PiAKPj4gT0ssIG15IGNhbmRp ZGF0ZSBiYWQgY29tbWl0IGlzIHRoaXMgb25lOgo+PiAKPj4gY29tbWl0IGEwNTYyODE5NWEwZDlm MzE3M2RkOWFhNzZmNDgyYWVmNjkyZTQ2ZWUKPj4gQXV0aG9yOiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+PiBEYXRlOsKgwqDCoE1vbiBBcHIgMTEgMTA6 MjM6NTEgMjAxNiArMDMwMAo+PiAKPj4gwqDCoMKgwqBkcm0vaTkxNTogR2V0IHBhbmVsX3R5cGUg ZnJvbSBPcFJlZ2lvbiBwYW5lbCBkZXRhaWxzCj4+IAo+PiBBZnRlciBiZWluZyBtb3JlIGNhcmVm dWwgYWJvdXQgd2FpdGluZyB0byBpZGVudGlmeSBmbGlja2VyLCB0aGlzIG9uZQo+PiBzZWVtcyB0 byBiZSB0aGUgb25lIHRoZSBiaXNlY3QgZmluZHMuwqDCoEknbSBub3cgcnVubmluZyB2NC43LXJj MyB3aXRoCj4+IHRoaXMgb25lIHJldmVydGVkIGFuZCBhbSBjdXJyZW50bHkgc2VlaW5nIG5vIGZs aWNrZXIgcHJvYmxlbXMuwqDCoEl0Cj4+IGlzLAo+PiBob3dldmVyLCBlYXJseSBkYXlzIGJlY2F1 c2UgdGhlIGZsaWNrZXIgY2FuIGhpZGUgZm9yIGxvbmcgcGVyaW9kcywgc28KPj4gSQo+PiAnbGwg d2FpdCB1bnRpbCBNb25kYXkgZXZlbmluZyBhbmQgYSBmZXcgcmVib290cyBiZWZvcmUgZGVjbGFy aW5nCj4+IHZpY3RvcnkuCj4+IAo+PsKgCj4gSSdtIHNlZWluZyB0aGlzIG9uIG15IEl2eUJyaWRn ZS4gwqBJJ2xsIHRyeSByZXZlcnRpbmcgdGhlIGNvbW1pdCBoZXJlCj4gdG9vLCB0byBzZWUgaWYg aXQncyB0aGUgc2FtZSBpc3N1ZS4KCkl2eUJyaWRnZSBkb2Vzbid0IGhhdmUgbG93IHZzd2luZyBm b3IgZURQLiBJZiByZXZlcnRpbmcgaGVscHMsIGl0J3MgYQpkaWZmZXJlbnQgZmFpbHVyZSBtb2Rl LgoKQlIsCkphbmkuCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xv Z3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbcFWM7x (ORCPT ); Thu, 23 Jun 2016 08:59:53 -0400 Received: from mga11.intel.com ([192.55.52.93]:54245 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357AbcFWM7w convert rfc822-to-8bit (ORCPT ); Thu, 23 Jun 2016 08:59:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,509,1459839600"; d="scan'208";a="1008148925" From: Jani Nikula To: Steven Newbury , James Bottomley , Daniel Vetter Cc: intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window In-Reply-To: <1466686369.6831.1.camel@snewbury.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1464638381.2240.3.camel@HansenPartnership.com> <871t4ibr7k.fsf@intel.com> <1464701638.2234.1.camel@HansenPartnership.com> <87mvmp9z03.fsf@intel.com> <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <1466686369.6831.1.camel@snewbury.org.uk> User-Agent: Notmuch/0.22+12~gbdd9442 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 23 Jun 2016 15:59:49 +0300 Message-ID: <87r3bohxh6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Jun 2016, Steven Newbury wrote: > [ Unknown signature status ] > On Sun, 2016-06-19 at 14:53 -0700, James Bottomley wrote: >> On Fri, 2016-06-17 at 16:06 -0700, James Bottomley wrote: >> > On Fri, 2016-06-17 at 16:34 +0300, Jani Nikula wrote: >> > > On Fri, 17 Jun 2016, Daniel Vetter wrote: >> > > > On Thu, Jun 16, 2016 at 03:42:12PM -0700, James Bottomley >> > > > wrote: >> > > > > On Thu, 2016-06-16 at 14:29 -0700, James Bottomley wrote: >> > > > > > On Thu, 2016-06-16 at 23:24 +0200, Daniel Vetter wrote: >> > > > > > > I guess we'll need the bisect on this one to make >> > > > > > > progress. >> > > > > > >> > > > > > Sigh, I was afraid that might be the next step. >> > > > > >> > > > > OK, I have a curious data point.  I assumed the problem would >> > > > > be >> > > > > somewhere in the drm update, so I started bisecting that at >> > > > > the >> > > > > top.  >> > > > >  However, the top most commit: >> > > > > >> > > > > commit 1d6da87a3241deb13d073c4125d19ed0e5a0c62c >> > > > > Merge: 1f40c49 a39ed68 >> > > > > Author: Linus Torvalds >> > > > > Date:   Mon May 23 11:48:48 2016 -0700 >> > > > > >> > > > >     Merge branch 'drm-next' of >> > > > > git://people.freedesktop.org/~airlied/linux >> > > > > >> > > > > Isn't actually bad.  There's no flicker here, so whatever >> > > > > caused >> > > > > the >> > > > > problem came from some update after this. >> > > > >> > > > There was a fixes pull after this. Might be worth it to >> > > > restrict >> > > > to >> > > > just >> > > > the i915 changes, which are just >> > > > 5b4fd5b1111b1230cd037..157d2c7fad0863222 >> > > > >> > > > Looking at those nothing seems to stick out which might explain >> > > > what's >> > > > happening for you. >> > >> > OK, so just on the firmware, the system seems less flickery with >> > the >> > new 1.4.3 UEFI, so I'm starting to think it is a Skylake errata  >> > issue.  The flicker isn't gone for good, but seems to be reboot  >> > dependent (it's there in some boots, but gone on a reboot). >> > >> > > This should be easy enough to try before bisecting: >> > > http://patchwork.freedesktop.org/patch/msgid/1466162081-12042-1-g >> > > it >> > > -s >> > > end-email-mika.kahola@intel.com >> > >> > Applying this didn't seem to make a difference: still there on >> > some  >> > and gone on other reboots. >> >> OK, my candidate bad commit is this one: >> >> commit a05628195a0d9f3173dd9aa76f482aef692e46ee >> Author: Ville Syrjälä >> Date:   Mon Apr 11 10:23:51 2016 +0300 >> >>     drm/i915: Get panel_type from OpRegion panel details >> >> After being more careful about waiting to identify flicker, this one >> seems to be the one the bisect finds.  I'm now running v4.7-rc3 with >> this one reverted and am currently seeing no flicker problems.  It >> is, >> however, early days because the flicker can hide for long periods, so >> I >> 'll wait until Monday evening and a few reboots before declaring >> victory. >> >>  > I'm seeing this on my IvyBridge.  I'll try reverting the commit here > too, to see if it's the same issue. IvyBridge doesn't have low vswing for eDP. If reverting helps, it's a different failure mode. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center