From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/dp/mst: Always clear proposed vcpi table for port. Date: Mon, 23 May 2016 11:38:15 +0300 Message-ID: <87r3ctdv9k.fsf@intel.com> References: <1463714317-14392-1-git-send-email-Andrey.Grodzovsky@amd.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1463714317-14392-1-git-send-email-Andrey.Grodzovsky@amd.com> Sender: stable-owner@vger.kernel.org To: dri-devel@lists.freedesktop.org Cc: Alexander.Deucher@amd.com, Andrey Grodzovsky , Mykola.Lysenko@amd.com, stable@vger.kernel.org, Harry Wentland , Dave Airlie , Lyude List-Id: dri-devel@lists.freedesktop.org Added some folks to Cc. On Fri, 20 May 2016, Andrey Grodzovsky wrote: > Not clearing mst manager's proposed vcpis table for destroyed > connectors when the manager is stopped leaves it pointing to > unrefernced memory, this causes pagefault when the manager is > restarted when plugging back a branch. You should list the relevant Cc's here too, and note where the bug was introduced. A quick glance suggests Fixes: 91a25e463130 ("drm/dp/mst: deallocate payload on port destruction") but Mykola hopefully knows better. BR, Jani. > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 9971c46..cd6014b 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2881,11 +2881,9 @@ static void drm_dp_destroy_connector_work(struct work_struct *work) > drm_dp_port_teardown_pdt(port, port->pdt); > > if (!port->input && port->vcpi.vcpi > 0) { > - if (mgr->mst_state) { > - drm_dp_mst_reset_vcpi_slots(mgr, port); > - drm_dp_update_payload_part1(mgr); > - drm_dp_mst_put_payload_id(mgr, port->vcpi.vcpi); > - } > + drm_dp_mst_reset_vcpi_slots(mgr, port); > + drm_dp_update_payload_part1(mgr); > + drm_dp_mst_put_payload_id(mgr, port->vcpi.vcpi); > } > > kref_put(&port->kref, drm_dp_free_mst_port); -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:25296 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753505AbcEWIiU (ORCPT ); Mon, 23 May 2016 04:38:20 -0400 From: Jani Nikula To: Andrey Grodzovsky , dri-devel@lists.freedesktop.org Cc: Alexander.Deucher@amd.com, Andrey Grodzovsky , Mykola.Lysenko@amd.com, stable@vger.kernel.org, Harry Wentland , Dave Airlie , Lyude Subject: Re: [PATCH] drm/dp/mst: Always clear proposed vcpi table for port. In-Reply-To: <1463714317-14392-1-git-send-email-Andrey.Grodzovsky@amd.com> References: <1463714317-14392-1-git-send-email-Andrey.Grodzovsky@amd.com> Date: Mon, 23 May 2016 11:38:15 +0300 Message-ID: <87r3ctdv9k.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: Added some folks to Cc. On Fri, 20 May 2016, Andrey Grodzovsky wrote: > Not clearing mst manager's proposed vcpis table for destroyed > connectors when the manager is stopped leaves it pointing to > unrefernced memory, this causes pagefault when the manager is > restarted when plugging back a branch. You should list the relevant Cc's here too, and note where the bug was introduced. A quick glance suggests Fixes: 91a25e463130 ("drm/dp/mst: deallocate payload on port destruction") but Mykola hopefully knows better. BR, Jani. > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 9971c46..cd6014b 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2881,11 +2881,9 @@ static void drm_dp_destroy_connector_work(struct work_struct *work) > drm_dp_port_teardown_pdt(port, port->pdt); > > if (!port->input && port->vcpi.vcpi > 0) { > - if (mgr->mst_state) { > - drm_dp_mst_reset_vcpi_slots(mgr, port); > - drm_dp_update_payload_part1(mgr); > - drm_dp_mst_put_payload_id(mgr, port->vcpi.vcpi); > - } > + drm_dp_mst_reset_vcpi_slots(mgr, port); > + drm_dp_update_payload_part1(mgr); > + drm_dp_mst_put_payload_id(mgr, port->vcpi.vcpi); > } > > kref_put(&port->kref, drm_dp_free_mst_port); -- Jani Nikula, Intel Open Source Technology Center