From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57782)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1agDGp-0006ZZ-5h
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 11:22:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1agDGo-00070t-1z
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 11:21:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45307)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1agDGn-00070p-T5
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 11:21:57 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1457571335-10938-1-git-send-email-eblake@redhat.com>
	<1457571335-10938-14-git-send-email-eblake@redhat.com>
	<87k2laozfq.fsf@blackfin.pond.sub.org> <56E1DE1E.9000608@redhat.com>
Date: Wed, 16 Mar 2016 16:21:55 +0100
In-Reply-To: <56E1DE1E.9000608@redhat.com> (Eric Blake's message of "Thu, 10
	Mar 2016 13:50:38 -0700")
Message-ID: <87r3faphws.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v5 13/14] qapi: Allow anonymous base for
	flat union
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

Eric Blake <eblake@redhat.com> writes:

> On 03/10/2016 01:22 PM, Markus Armbruster wrote:
>> Eric Blake <eblake@redhat.com> writes:
>> 
>>> Rather than requiring all flat unions to explicitly create
>>> a separate base struct, we can allow the qapi schema to specify
>>> the common members via an inline dictionary. This is similar to
>>> how commands can specify an inline anonymous type for its 'data'.
>>> We already have several struct types that only exist to serve as
>>> a single flat union's base; the next commit will clean them up
>>> (in particular, the doc change to the BlockdevOptions example in
>>> this patch will be reflected to QMP in the next).
>> 
>> The parenthesis is a bit cryptic.  "Reflected"?
>
> Maybe s/reflected to/implemented in/ would read better.

What about:

    a single flat union's base; the next commit will clean them up.
    In particular, this patch's change to the BlockdevOptions example
    in qapi-code-gen.txt will actually be done in the real QAPI schema.

[...]