From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aePae-0004XS-Lc
	for qemu-devel@nongnu.org; Fri, 11 Mar 2016 11:07:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aePab-0003Cs-OY
	for qemu-devel@nongnu.org; Fri, 11 Mar 2016 11:07:00 -0500
Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:34371)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aePab-0003Co-Hd
	for qemu-devel@nongnu.org; Fri, 11 Mar 2016 11:06:57 -0500
Received: by mail-wm0-x22c.google.com with SMTP id p65so23917132wmp.1
	for <qemu-devel@nongnu.org>; Fri, 11 Mar 2016 08:06:57 -0800 (PST)
References: <1457086720-30391-1-git-send-email-famz@redhat.com>
	<1457086720-30391-6-git-send-email-famz@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1457086720-30391-6-git-send-email-famz@redhat.com>
Date: Fri, 11 Mar 2016 16:06:55 +0000
Message-ID: <87r3fht2w0.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 05/13] docker: Add common.rc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de, qemu-devel@nongnu.org, stefanha@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, jsnow@redhat.com, david@gibson.dropbear.id.au


Fam Zheng <famz@redhat.com> writes:

> "requires" checks the "FEATURE" environment for specified prerequisits,
> and skip the execution of test if not found.

You also add a build_qemu function which you should mention.

Otherwise have a:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/common.rc | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100755 tests/docker/common.rc
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> new file mode 100755
> index 0000000..74b89d6
> --- /dev/null
> +++ b/tests/docker/common.rc
> @@ -0,0 +1,31 @@
> +#!/bin/sh
> +#
> +# Common routines for docker test scripts.
> +#
> +# Copyright (c) 2016 Red Hat Inc.
> +#
> +# Authors:
> +#  Fam Zheng <famz@redhat.com>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2
> +# or (at your option) any later version. See the COPYING file in
> +# the top-level directory.
> +
> +requires()
> +{
> +    for c in $@; do
> +        if ! echo "$FEATURES" | grep -wq -e "$c"; then
> +            echo "Prerequisite '$c' not present, skip"
> +            exit 0
> +        fi
> +    done
> +}
> +
> +build_qemu()
> +{
> +    $QEMU_SRC/configure \
> +        --target-list="${TARGET_LIST}" \
> +        --prefix="$PWD/install" \
> +        "$@"
> +    make $MAKEFLAGS
> +}


--
Alex Bennée