From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id gb9sm15080579wjb.26.2016.02.05.01.52.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Feb 2016 01:52:17 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTPS id CB87C3E025C; Fri, 5 Feb 2016 09:52:16 +0000 (GMT) References: <1454506721-11843-1-git-send-email-peter.maydell@linaro.org> <1454506721-11843-2-git-send-email-peter.maydell@linaro.org> User-agent: mu4e 0.9.17; emacs 25.0.90.1 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Peter Maydell Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, patches@linaro.org Subject: Re: [Qemu-arm] [PATCH 1/7] target-arm: Fix typo in comment in arm_is_secure_below_el3() In-reply-to: <1454506721-11843-2-git-send-email-peter.maydell@linaro.org> Date: Fri, 05 Feb 2016 09:52:16 +0000 Message-ID: <87r3gro567.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-TUID: KLheJ0Hbsg92 Peter Maydell writes: > Fix a typo where "EL2" was written but "EL3" intended. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > index b8b3364..52284e9 100644 > --- a/target-arm/cpu.h > +++ b/target-arm/cpu.h > @@ -931,7 +931,7 @@ static inline bool arm_is_secure_below_el3(CPUARMState *env) > if (arm_feature(env, ARM_FEATURE_EL3)) { > return !(env->cp15.scr_el3 & SCR_NS); > } else { > - /* If EL2 is not supported then the secure state is implementation > + /* If EL3 is not supported then the secure state is implementation > * defined, in which case QEMU defaults to non-secure. > */ > return false; Reviewed-by: Alex Bennée -- Alex Bennée From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRd3w-0005iJ-EI for qemu-devel@nongnu.org; Fri, 05 Feb 2016 04:52:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRd3t-0005mI-8x for qemu-devel@nongnu.org; Fri, 05 Feb 2016 04:52:24 -0500 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:34719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRd3t-0005mD-20 for qemu-devel@nongnu.org; Fri, 05 Feb 2016 04:52:21 -0500 Received: by mail-wm0-x22a.google.com with SMTP id 128so63076376wmz.1 for ; Fri, 05 Feb 2016 01:52:20 -0800 (PST) References: <1454506721-11843-1-git-send-email-peter.maydell@linaro.org> <1454506721-11843-2-git-send-email-peter.maydell@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1454506721-11843-2-git-send-email-peter.maydell@linaro.org> Date: Fri, 05 Feb 2016 09:52:16 +0000 Message-ID: <87r3gro567.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH 1/7] target-arm: Fix typo in comment in arm_is_secure_below_el3() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org Peter Maydell writes: > Fix a typo where "EL2" was written but "EL3" intended. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > index b8b3364..52284e9 100644 > --- a/target-arm/cpu.h > +++ b/target-arm/cpu.h > @@ -931,7 +931,7 @@ static inline bool arm_is_secure_below_el3(CPUARMState *env) > if (arm_feature(env, ARM_FEATURE_EL3)) { > return !(env->cp15.scr_el3 & SCR_NS); > } else { > - /* If EL2 is not supported then the secure state is implementation > + /* If EL3 is not supported then the secure state is implementation > * defined, in which case QEMU defaults to non-secure. > */ > return false; Reviewed-by: Alex Bennée -- Alex Bennée