From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Christoffer Dall <christoffer.dall@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
kvm-devel <kvm@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs
Date: Mon, 09 Mar 2015 16:25:58 +0000 [thread overview]
Message-ID: <87r3syb0ix.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_DqHx-sDMuhSr0-uQL20-uJzXXpBvr6YLUWmzMN2mL4w@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 9 March 2015 at 21:56, Christoffer Dall <christoffer.dall@linaro.org> wrote:
>> this function, however, is not used only when migration, but should
>> generally cover the case where you want to synchronize QEMU's state into
>> KVM's state, right? So while it may not be harmful in currently
>> supported use cases, is there ever a situation where (is_a64(env) && el
>> == 0) and env->spsr != banked_spsr[el], and where env->spsr is
>> out-of-date?
>
> If EL == 0 then you can't access any SPSR, so env->spsr is by
> definition out of date.
Indeed and in v2 the whole thing is wrapped in if (el > 0)
>
> -- PMM
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: alex.bennee@linaro.org (Alex Bennée)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs
Date: Mon, 09 Mar 2015 16:25:58 +0000 [thread overview]
Message-ID: <87r3syb0ix.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_DqHx-sDMuhSr0-uQL20-uJzXXpBvr6YLUWmzMN2mL4w@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 9 March 2015 at 21:56, Christoffer Dall <christoffer.dall@linaro.org> wrote:
>> this function, however, is not used only when migration, but should
>> generally cover the case where you want to synchronize QEMU's state into
>> KVM's state, right? So while it may not be harmful in currently
>> supported use cases, is there ever a situation where (is_a64(env) && el
>> == 0) and env->spsr != banked_spsr[el], and where env->spsr is
>> out-of-date?
>
> If EL == 0 then you can't access any SPSR, so env->spsr is by
> definition out of date.
Indeed and in v2 the whole thing is wrapped in if (el > 0)
>
> -- PMM
--
Alex Benn?e
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Christoffer Dall <christoffer.dall@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
kvm-devel <kvm@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
"kvmarm\@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs
Date: Mon, 09 Mar 2015 16:25:58 +0000 [thread overview]
Message-ID: <87r3syb0ix.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_DqHx-sDMuhSr0-uQL20-uJzXXpBvr6YLUWmzMN2mL4w@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 9 March 2015 at 21:56, Christoffer Dall <christoffer.dall@linaro.org> wrote:
>> this function, however, is not used only when migration, but should
>> generally cover the case where you want to synchronize QEMU's state into
>> KVM's state, right? So while it may not be harmful in currently
>> supported use cases, is there ever a situation where (is_a64(env) && el
>> == 0) and env->spsr != banked_spsr[el], and where env->spsr is
>> out-of-date?
>
> If EL == 0 then you can't access any SPSR, so env->spsr is by
> definition out of date.
Indeed and in v2 the whole thing is wrapped in if (el > 0)
>
> -- PMM
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Christoffer Dall <christoffer.dall@linaro.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>
Subject: Re: [Qemu-devel] [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs
Date: Mon, 09 Mar 2015 16:25:58 +0000 [thread overview]
Message-ID: <87r3syb0ix.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_DqHx-sDMuhSr0-uQL20-uJzXXpBvr6YLUWmzMN2mL4w@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 9 March 2015 at 21:56, Christoffer Dall <christoffer.dall@linaro.org> wrote:
>> this function, however, is not used only when migration, but should
>> generally cover the case where you want to synchronize QEMU's state into
>> KVM's state, right? So while it may not be harmful in currently
>> supported use cases, is there ever a situation where (is_a64(env) && el
>> == 0) and env->spsr != banked_spsr[el], and where env->spsr is
>> out-of-date?
>
> If EL == 0 then you can't access any SPSR, so env->spsr is by
> definition out of date.
Indeed and in v2 the whole thing is wrapped in if (el > 0)
>
> -- PMM
--
Alex Bennée
next prev parent reply other threads:[~2015-03-09 16:25 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 16:02 [PATCH 0/6] QEMU ARM64 Migration Fixes Alex Bennée
2015-02-25 16:02 ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02 ` Alex Bennée
2015-02-25 16:02 ` [PATCH 1/6] target-arm: kvm: save/restore mp state Alex Bennée
2015-02-25 16:02 ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02 ` Alex Bennée
2015-02-25 23:36 ` Peter Maydell
2015-02-25 23:36 ` [Qemu-devel] " Peter Maydell
2015-02-25 23:36 ` Peter Maydell
2015-03-03 10:56 ` Alex Bennée
2015-03-03 10:56 ` [Qemu-devel] " Alex Bennée
2015-03-03 10:56 ` Alex Bennée
2015-03-03 11:06 ` Paolo Bonzini
2015-03-03 11:06 ` [Qemu-devel] " Paolo Bonzini
2015-03-03 11:06 ` Paolo Bonzini
2015-03-03 11:51 ` Peter Maydell
2015-03-03 11:51 ` [Qemu-devel] " Peter Maydell
2015-03-03 11:51 ` Peter Maydell
2015-03-03 16:30 ` Alex Bennée
2015-03-03 16:30 ` [Qemu-devel] " Alex Bennée
2015-03-03 16:30 ` Alex Bennée
2015-03-03 17:10 ` Paolo Bonzini
2015-03-03 17:10 ` [Qemu-devel] " Paolo Bonzini
2015-03-03 17:10 ` Paolo Bonzini
2015-02-26 12:57 ` Paolo Bonzini
2015-02-26 12:57 ` [Qemu-devel] " Paolo Bonzini
2015-02-26 12:57 ` Paolo Bonzini
2015-02-25 16:02 ` [PATCH 2/6] arm_gic_kvm.c: restore config before pending IRQs Alex Bennée
2015-02-25 16:02 ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02 ` Alex Bennée
2015-03-02 22:14 ` Christoffer Dall
2015-03-02 22:14 ` [Qemu-devel] " Christoffer Dall
2015-03-02 22:14 ` Christoffer Dall
2015-02-25 16:02 ` [PATCH 3/6] hw/char/pl011: don't keep setting the IRQ if nothing changed Alex Bennée
2015-02-25 16:02 ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02 ` Alex Bennée
2015-02-25 16:02 ` [PATCH 4/6] target-arm/kvm64.c: sync FP register state Alex Bennée
2015-02-25 16:02 ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02 ` Alex Bennée
2015-02-25 16:02 ` [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR registers Alex Bennée
2015-02-25 16:02 ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02 ` Alex Bennée
2015-02-25 16:02 ` [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs Alex Bennée
2015-02-25 16:02 ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02 ` Alex Bennée
2015-03-02 17:22 ` Christoffer Dall
2015-03-02 17:22 ` [Qemu-devel] " Christoffer Dall
2015-03-02 17:22 ` Christoffer Dall
2015-03-03 11:28 ` Alex Bennée
2015-03-03 11:28 ` [Qemu-devel] " Alex Bennée
2015-03-03 11:28 ` Alex Bennée
2015-03-09 12:56 ` Christoffer Dall
2015-03-09 12:56 ` [Qemu-devel] " Christoffer Dall
2015-03-09 12:56 ` Christoffer Dall
2015-03-09 13:31 ` Peter Maydell
2015-03-09 13:31 ` [Qemu-devel] " Peter Maydell
2015-03-09 13:31 ` Peter Maydell
2015-03-09 16:25 ` Alex Bennée [this message]
2015-03-09 16:25 ` [Qemu-devel] " Alex Bennée
2015-03-09 16:25 ` Alex Bennée
2015-03-09 16:25 ` Alex Bennée
2015-03-09 19:31 ` Christoffer Dall
2015-03-09 19:31 ` [Qemu-devel] " Christoffer Dall
2015-03-09 19:31 ` Christoffer Dall
2015-02-25 16:02 ` [PATCH 6/6] target-arm/cpu.h: document why env->spsr exists Alex Bennée
2015-02-25 16:02 ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02 ` Alex Bennée
2015-03-11 15:39 ` [Qemu-devel] " Greg Bellows
2015-03-11 15:39 ` Greg Bellows
2015-03-11 15:39 ` Greg Bellows
2015-03-11 15:47 ` Peter Maydell
2015-03-11 15:47 ` [Qemu-devel] " Peter Maydell
2015-03-11 15:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3syb0ix.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.