Re: [PATCH 1/2] virtio_pci_modern: type-safe io accessors

[Rusty Russell <rusty@rustcorp.com.au>]

Rusty Russell <rusty@rustcorp.com.au> writes:

> "Michael S. Tsirkin" <mst@redhat.com> writes:
>> The spec is very clear on this:
>>
>> 4.1.3.1 Driver Requirements: PCI Device Layout
>>
>> The driver MUST access each field using the “natural” access method,
>> i.e. 32-bit accesses for 32-bit fields, 16-bit accesses for 16-bit
>> fields and 8-bit accesses for 8-bit fields.
>>
>> Add type-safe wrappers to prevent access with incorrect width.
>
> Applied both (for *next* merge window).

... and fixed this:

>> +static inline void vp_iowrite32(u32 value, u32 __iomem *addr)
>> +{
>> +	iowrite16(value, addr);
>> +}

Thanks,
Rusty.