From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Date: Thu, 20 Nov 2014 10:52:43 +0000 Subject: Re: [PATCH] KVM: PPC: Book3S HV: Tracepoints for KVM HV guest interactions Message-Id: <87r3wy6tp0.fsf@linux.vnet.ibm.com> List-Id: References: <54653EBC.2020805@linux.vnet.ibm.com> In-Reply-To: <54653EBC.2020805@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Suresh E. Warrier" , agraf@suse.de, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org Cc: Paul Mackerras "Suresh E. Warrier" writes: > This patch adds trace points in the guest entry and exit code and also > for exceptions handled by the host in kernel mode - hypercalls and page > faults. The new events are added to /sys/kernel/debug/tracing/events > under a new subsystem called kvm_hv. ........ > /* Set this explicitly in case thread 0 doesn't have a vcpu */ > @@ -1687,6 +1691,9 @@ static void kvmppc_run_core(struct kvmppc_vcore *vc) > > vc->vcore_state = VCORE_RUNNING; > preempt_disable(); > + > + trace_kvmppc_run_core(vc, 0); > + > spin_unlock(&vc->lock); Do we really want to call tracepoint with spin lock held ? Is that a good thing to do ?. -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH] KVM: PPC: Book3S HV: Tracepoints for KVM HV guest interactions Date: Thu, 20 Nov 2014 16:10:43 +0530 Message-ID: <87r3wy6tp0.fsf@linux.vnet.ibm.com> References: <54653EBC.2020805@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Paul Mackerras To: "Suresh E. Warrier" , agraf@suse.de, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org Return-path: Received: from e28smtp08.in.ibm.com ([122.248.162.8]:35813 "EHLO e28smtp08.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756136AbaKTKlB (ORCPT ); Thu, 20 Nov 2014 05:41:01 -0500 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Nov 2014 16:10:54 +0530 In-Reply-To: <54653EBC.2020805@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: "Suresh E. Warrier" writes: > This patch adds trace points in the guest entry and exit code and also > for exceptions handled by the host in kernel mode - hypercalls and page > faults. The new events are added to /sys/kernel/debug/tracing/events > under a new subsystem called kvm_hv. ........ > /* Set this explicitly in case thread 0 doesn't have a vcpu */ > @@ -1687,6 +1691,9 @@ static void kvmppc_run_core(struct kvmppc_vcore *vc) > > vc->vcore_state = VCORE_RUNNING; > preempt_disable(); > + > + trace_kvmppc_run_core(vc, 0); > + > spin_unlock(&vc->lock); Do we really want to call tracepoint with spin lock held ? Is that a good thing to do ?. -aneesh