From: av1474@comtv.ru
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: powerpc: Avoid bashisms in prom_init_check.sh
Date: Fri, 12 Sep 2014 22:55:38 +0400 [thread overview]
Message-ID: <87r3zgd5xx.fsf_-_@comtv.ru> (raw)
In-Reply-To: <1410510342.17540.10.camel@concordia> (Michael Ellerman's message of "Fri, 12 Sep 2014 18:25:42 +1000")
>From 300a98f895dc7e2167cf379408322a9607907761 Mon Sep 17 00:00:00 2001
From: malc <av1474 at comtv.ru>
Date: Mon, 4 Aug 2014 23:28:05 +0400
Subject: [PATCH] powerpc: Avoid bashisms in prom_init_check.sh
Signed-off-by: Vassili Karpov <av1474@comtv.ru>
---
arch/powerpc/kernel/prom_init_check.sh | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
index fe8e54b..413f792 100644
--- a/arch/powerpc/kernel/prom_init_check.sh
+++ b/arch/powerpc/kernel/prom_init_check.sh
@@ -50,22 +50,22 @@ do
done
# ignore register save/restore funcitons
- if [ "${UNDEF:0:9}" = "_restgpr_" ]; then
+ if [ "$(printf %.9s $UNDEF)" = "_restgpr_" ]; then
OK=1
fi
- if [ "${UNDEF:0:10}" = "_restgpr0_" ]; then
+ if [ "$(printf %.10s $UNDEF)" = "_restgpr0_" ]; then
OK=1
fi
- if [ "${UNDEF:0:11}" = "_rest32gpr_" ]; then
+ if [ "$(printf %.11s $UNDEF)" = "_rest32gpr_" ]; then
OK=1
fi
- if [ "${UNDEF:0:9}" = "_savegpr_" ]; then
+ if [ "$(printf %.9s $UNDEF)" = "_savegpr_" ]; then
OK=1
fi
- if [ "${UNDEF:0:10}" = "_savegpr0_" ]; then
+ if [ "$(printf %.10s $UNDEF)" = "_savegpr0_" ]; then
OK=1
fi
- if [ "${UNDEF:0:11}" = "_save32gpr_" ]; then
+ if [ "$(printf %.11s $UNDEF)" = "_save32gpr_" ]; then
OK=1
fi
--
2.0.0.GIT
> On Mon, 2014-08-04 at 23:36 +0400, av1474@comtv.ru wrote:
>> From 300a98f895dc7e2167cf379408322a9607907761 Mon Sep 17 00:00:00 2001
>> From: malc <av1474@comtv.ru>
>> Date: Mon, 4 Aug 2014 23:28:05 +0400
>> Subject: [PATCH] Avoid bashisms
>
> Hi malc,
>
> If you want us to take your patch, please resend with:
> - a better subject, eg:
> powerpc: Avoid bashisms in prom_init_check.sh
> - a Signed-off-by line.
>
> cheers
Thanks for suggestions,
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2014-09-12 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 19:36 [PATCH] Avoid bashisms av1474
2014-09-12 8:25 ` Michael Ellerman
2014-09-12 18:55 ` av1474 [this message]
[not found] ` <87r3zgd5xx.fsf_-___23348.7322264866$1410551821$gmane$org@comtv.ru>
2014-09-13 8:20 ` [PATCH] Simplify symbol check in prom_init_check.sh Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3zgd5xx.fsf_-_@comtv.ru \
--to=av1474@comtv.ru \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.