From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH v3 2/2] virtio-rng: skip reading when we start to remove the device Date: Fri, 12 Sep 2014 11:07:26 +0930 Message-ID: <87r3zhhb55.fsf@rustcorp.com.au> References: <1410329497-14349-1-git-send-email-akong@redhat.com> <1410329497-14349-3-git-send-email-akong@redhat.com> <20140910070444.GD29832@grmbl.mre> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140910070444.GD29832@grmbl.mre> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Amit Shah , Amos Kong Cc: stable@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org Amit Shah writes: > On (Wed) 10 Sep 2014 [14:11:37], Amos Kong wrote: >> Before we really unregister the hwrng device, reading will get stuck if >> the virtio device is reset. We should return error for reading when we >> start to remove the device. >> >> Signed-off-by: Amos Kong >> Cc: stable@vger.kernel.org > > Reviewed-by: Amit Shah Thanks, applied. They're sitting in my fixes branch. If there are no screams from linux-next, I'll push to Linus Monday. Cheers, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Rusty Russell To: Amit Shah , Amos Kong Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 2/2] virtio-rng: skip reading when we start to remove the device In-Reply-To: <20140910070444.GD29832@grmbl.mre> References: <1410329497-14349-1-git-send-email-akong@redhat.com> <1410329497-14349-3-git-send-email-akong@redhat.com> <20140910070444.GD29832@grmbl.mre> Date: Fri, 12 Sep 2014 11:07:26 +0930 Message-ID: <87r3zhhb55.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah writes: > On (Wed) 10 Sep 2014 [14:11:37], Amos Kong wrote: >> Before we really unregister the hwrng device, reading will get stuck if >> the virtio device is reset. We should return error for reading when we >> start to remove the device. >> >> Signed-off-by: Amos Kong >> Cc: stable@vger.kernel.org > > Reviewed-by: Amit Shah Thanks, applied. They're sitting in my fixes branch. If there are no screams from linux-next, I'll push to Linus Monday. Cheers, Rusty.