Re: [PATCH v3] ath10k: fix Rx aggregation reordering

[Kalle Valo <kvalo@qca.qualcomm.com>]

(dropping linux-wireless)

Michal Kazior <michal.kazior@tieto.com> writes:

> Firmware doesn't perform Rx reordering so it is
> left to the host driver to do that.
>
> Use mac80211 to perform reordering instead of
> re-inventing the wheel.
>
> This fixes TCP throughput issues in some
> environments.
>
> Reported-by: Denton Gentry <denton.gentry@gmail.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> ---
> This depends on:
>
>  * mac80211: fix Rx reordering with RX_FLAG_AMSDU_MORE
>  * mac80211: add support for Rx reordering offloading
>
> I'm still seeing some issues with TCP traffic.
> Apparently firmware/hardware sometimes stalls Rx
> for ~100ms and misses some aggregate frames. I
> wasn't able to pinpoint what the problem is. The
> more parallel TCP streams (iperf) the more often
> stalls happen. UDP doesn't seem to trigger the Rx
> stalls at all.

The mac80211 patches are in mac80211-next, but I can only apply this one
only once they are in wireless-next.

Also the other thing is that 3.17 merge window is very close. I might be
able to squeeze this in but there's the risk that this patch hasn't
received enough testing from being in ath.git. How safe (or risky) is
this patch? If we push this to 3.17, we could try to fix regressions in
-rc releases but that's always more difficult than waiting for 3.18.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k