From: Jani Nikula <jani.nikula@intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Drop unecessary casts in i915_irq.c
Date: Mon, 12 May 2014 20:36:13 +0300 [thread overview]
Message-ID: <87r43yrjaq.fsf@intel.com> (raw)
In-Reply-To: <1399915104-2470-1-git-send-email-daniel.vetter@ffwll.ch>
On Mon, 12 May 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Inspired by a review bikeshed from Jani.
>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index e5ec3e5ca37c..b10fbde1d5ee 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1668,7 +1668,7 @@ static void i9xx_hpd_irq_handler(struct drm_device *dev)
>
> static irqreturn_t valleyview_irq_handler(int irq, void *arg)
> {
> - struct drm_device *dev = (struct drm_device *) arg;
> + struct drm_device *dev = arg;
> struct drm_i915_private *dev_priv = dev->dev_private;
> u32 iir, gt_iir, pm_iir;
> irqreturn_t ret = IRQ_NONE;
> @@ -1705,7 +1705,7 @@ out:
>
> static irqreturn_t cherryview_irq_handler(int irq, void *arg)
> {
> - struct drm_device *dev = (struct drm_device *) arg;
> + struct drm_device *dev = arg;
> struct drm_i915_private *dev_priv = dev->dev_private;
> u32 master_ctl, iir;
> irqreturn_t ret = IRQ_NONE;
> @@ -2024,7 +2024,7 @@ static void ivb_display_irq_handler(struct drm_device *dev, u32 de_iir)
>
> static irqreturn_t ironlake_irq_handler(int irq, void *arg)
> {
> - struct drm_device *dev = (struct drm_device *) arg;
> + struct drm_device *dev = arg;
> struct drm_i915_private *dev_priv = dev->dev_private;
> u32 de_iir, gt_iir, de_ier, sde_ier = 0;
> irqreturn_t ret = IRQ_NONE;
> @@ -3642,7 +3642,7 @@ static bool i8xx_handle_vblank(struct drm_device *dev,
>
> static irqreturn_t i8xx_irq_handler(int irq, void *arg)
> {
> - struct drm_device *dev = (struct drm_device *) arg;
> + struct drm_device *dev = arg;
> struct drm_i915_private *dev_priv = dev->dev_private;
> u16 iir, new_iir;
> u32 pipe_stats[2];
> @@ -3827,7 +3827,7 @@ static bool i915_handle_vblank(struct drm_device *dev,
>
> static irqreturn_t i915_irq_handler(int irq, void *arg)
> {
> - struct drm_device *dev = (struct drm_device *) arg;
> + struct drm_device *dev = arg;
> struct drm_i915_private *dev_priv = dev->dev_private;
> u32 iir, new_iir, pipe_stats[I915_MAX_PIPES];
> unsigned long irqflags;
> @@ -4057,7 +4057,7 @@ static void i915_hpd_irq_setup(struct drm_device *dev)
>
> static irqreturn_t i965_irq_handler(int irq, void *arg)
> {
> - struct drm_device *dev = (struct drm_device *) arg;
> + struct drm_device *dev = arg;
> struct drm_i915_private *dev_priv = dev->dev_private;
> u32 iir, new_iir;
> u32 pipe_stats[I915_MAX_PIPES];
> --
> 1.9.2
>
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-05-12 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 17:18 [PATCH] drm/i915: Drop unecessary casts in i915_irq.c Daniel Vetter
2014-05-12 17:36 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r43yrjaq.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.